Issue 15816 - The dmake program does not cleanly end tempfiles with a linefeed
Summary: The dmake program does not cleanly end tempfiles with a linefeed
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: Other Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: foskey
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-19 14:49 UTC by foskey
Modified: 2003-12-20 12:40 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Switch on the trailing linefeed (590 bytes, patch)
2003-06-19 14:51 UTC, foskey 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2003-06-19 14:49:39 UTC 
This breaks not GNU tool sets like AIX.  The attached patch simply forces the
extra linefeed to be inserted into the temporary files when created.  This has
been applied on Linux and built end to end from scratch.
Comment 1 foskey 2003-06-19 14:51:12 UTC 
Created attachment 6996 [details]
Switch on the trailing linefeed
Comment 2 Martin Hollmichel 2003-06-23 13:53:27 UTC 
mh->warath: I assume, this has been test on other platforms as well ?
what about windows ?
Comment 3 quetschke 2003-06-23 17:56:35 UTC 
I'll try once the tree builds again for me. Propably later tonight.
Comment 4 quetschke 2003-06-26 17:52:39 UTC 
I'm just building a W32-tcsh build with this patch. Seems to work.
Comment 5 quetschke 2003-06-30 15:36:58 UTC 
A full W32-tcsh build completed.
Comment 6 foskey 2003-07-21 05:43:27 UTC 
Will apply to RC3
Comment 7 foskey 2003-07-21 15:58:58 UTC 
Applied to RC3.
Comment 8 foskey 2003-12-20 12:40:08 UTC 
verified.
Comment 9 foskey 2003-12-20 12:40:53 UTC 
closed.