Issue 15895 - sal/osl/unx/system.h and FreeBSD
Summary: sal/osl/unx/system.h and FreeBSD
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Martin Hollmichel
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-21 14:41 UTC by pavel
Modified: 2003-06-21 16:00 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-06-21 14:41:41 UTC 
Hi,

there is this code on line 227:

#ifdef __FreeBSD_version < 500000

which is invalid preprocessor usage (#ifdef and conditional).

Can I commit this?

--- system.h.~1.17.34.1.~	2003-06-18 23:50:16.000000000 +0200
+++ system.h	2003-06-21 15:38:38.000000000 +0200
@@ -224,7 +224,7 @@
 #   include <netinet/tcp.h>
 #	define 	IORESOURCE_TRANSFER_BSD 
 #   include <machine/endian.h>
-#ifdef __FreeBSD_version < 500000
+#if __FreeBSD_version < 500000
 #   if BYTE_ORDER == LITTLE_ENDIAN
 #   	define _LITTLE_ENDIAN
 #   elif BYTE_ORDER == BIG_ENDIAN
Comment 1 pavel 2003-06-21 15:43:47 UTC 
Approved by Kevin in dev@porting.

Commited.
Comment 2 pavel 2003-06-21 15:50:44 UTC 
Fixed.
Comment 3 pavel 2003-06-21 16:00:53 UTC 
-