Issue 16682 - broken (far too small) font sizing - different from desktop & desktop settings
Summary: broken (far too small) font sizing - different from desktop & desktop settings
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: ru
QA Contact: issues@gsl
URL:
Keywords:
: 20895 (view as issue list)
Depends on:
Blocks:
 
Reported: 2003-07-10 18:40 UTC by mmeeks
Modified: 2004-04-28 14:49 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-07-10 18:40:23 UTC
The code in vcl/source/window/window.cxx:397

    if( 1 )
    {
        // #97047: Force all fonts except Mneu and Help to a fixed height
        // to avoid UI scaling due to large fonts
        StyleSettings aStyleSettings = rSettings.GetStyleSettings();

        // #107886# allow scaling of the UI if the menu font is 
        //  slightly larger/smaller than the 8pt default
        int defFontheight = 8;
        Font aFont = aStyleSettings.GetMenuFont();
        if( abs(aFont.GetHeight() - defFontheight) == 1 )
            defFontheight = aFont.GetHeight();

        aFont = aStyleSettings.GetAppFont();
        aFont.SetHeight( defFontheight );
        aStyleSettings.SetAppFont( aFont );

etc. badly screws up the work put into font size synchronization under Unix.

Without that branch, it works rather well.
Comment 1 christof.pintaske 2003-07-14 09:48:45 UTC
cp->ssa: this is actually the same as #107886#. Is there a specific
reason to let the size only differ by 1 ?
Comment 2 christof.pintaske 2003-07-14 10:04:30 UTC
cp->ssa: see also #110754#
Comment 3 stephan_schaefer 2003-07-14 10:29:39 UTC
The whole if(1) - block was introduced for accessibility reasons. We
only want to have our menues using the system's font height. The
dialog font size however, should be fixed to 8pt. This was to assure
that dialogs will not exceed the screen size - which typically occured
when switching to some HighContrast color scheme on Windows (which
also increases font sizes a lot). 
Now, our korean friends had a problem with the 8pt size of their UI
font which is not readable very well at this size. Thus, we allow a
setting of 9pt as well, if the system says so. On korean Windows the
UI font is actually set to 9pt.
In my eyes the -1 check is the problematic hack here - we should be
more tolerant and allow for a slightly bigger range to better reflect
the system's font sizes. But being too tolerant will definitely lead
to dialogs not fitting on screen anymore.
Another change I'd like to make is to set the minimum size to 9pt when
running with a korean UI. This would allow for a readable korean UI on
non-korean locales. 

Michael, what font size is your desktop reporting ?
Comment 4 christof.pintaske 2003-07-14 14:45:07 UTC
these ibis frontend makes me climbing up the wall
Comment 5 christof.pintaske 2003-07-14 14:46:05 UTC
reassign NOT resolve
Comment 6 mmeeks 2003-07-14 17:11:59 UTC
So all my desktops are better than 1400x1050 at ~100dpi.

At that size an 8point font is eye-strainingly difficult to read.

Thus I configure my system to use a 12 point font - which works nicely
for everything except OO.o - where the text is unreadable.

If there is a problem on windows - such that the font sizes are
mangled badly; it'd be nice not to cripple Unix systems where it's
sensible to have higher font sizes :-) can the font size not be
clobbered in the app.

Also - it seems profoundly inaccessible to me to have 1 font size
which is what the (visually impaired) user selected for Menus - and
then expect him/her to be able to read substantially smaller 8point
font in all dialogs, buttons, combo boxes etc. - that's surely just daft.

Clearly - if the user selects a gargantuan font size, then the app
will become unusable - but surely, that's always going to be the case
- cropping it IMHO creates a worse problem than it solves.

Obviously going forward - a toolkit with layout can do  a lot better
job of ensuring the dialogs are nicely packed and far smaller - that's
the right long-term solution IMHO.

Thanks.

Comment 7 stephan_schaefer 2003-07-14 17:20:01 UTC
So we should check the screen resolution as well to find a font size
that guarantees on-screen dialogs.


Comment 8 mmeeks 2003-07-15 09:42:55 UTC
If you insist on adding such 'nanny' code - then can you ensure it is
easy to disable - perhaps an environment variable or somesuch - so we
don't have to patch this out of our OO.o on an ongoing basis.

Thanks.
Comment 9 stephan_schaefer 2003-11-24 10:08:22 UTC
To make sure that no dialog exceeds the screen size, the UI font will
be allowed to grow by the ratio between the user's desktop size and
the desktop size that was used when designing the dialogs, ie 800x600.
In the case of a 1400x1050 desktop, that would allow for a UI font
size of 14pt.

Comment 10 stephan_schaefer 2003-11-24 13:46:53 UTC
*** Issue 20895 has been marked as a duplicate of this issue. ***
Comment 11 stephan_schaefer 2003-11-26 14:01:25 UTC
Fixed in CWS vcl17. See also #i21238#.

Comment 12 stephan_schaefer 2004-01-23 12:00:44 UTC
ss->ru: please verify in CWS vcl17.
Comment 13 ru 2004-01-27 16:29:30 UTC
.
Comment 14 ru 2004-01-27 16:29:51 UTC
.
Comment 15 ru 2004-04-28 14:49:49 UTC
.