Issue 18637 - Code cleanup required for Master and Java based ScriptProviders
Summary: Code cleanup required for Master and Java based ScriptProviders
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: scripting (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: noel.power
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-25 15:39 UTC by tomaisoc
Modified: 2005-01-06 15:24 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tomaisoc 2003-08-25 15:39:42 UTC 
Following a code inspection the following areas have been identified as
needing cleanup or refactoring in the Scripting Framework code:

- Update Provider IDL specifications to have a service hierarchy
- Refactor MasterScriptProvider creation, initialization and getScript methods
- Rename ScriptRuntimeFor* classes to ScriptProviderFor*
- Remove XScriptInfo as a parameter to ScriptContext constructor
- Rename SomeResolver to ScriptResolver and refactor resolve method
- Remove unused static boolean for JRE version number and static initialiser code
Comment 1 tomaisoc 2003-08-25 15:40:19 UTC 
Set target to OOo 2.0
Comment 2 tomaisoc 2003-08-27 15:16:48 UTC 
Made the following changes:

- Added a new LogUtils class and moved DEBUG method from
  ScriptRuntimeForJava to this class.
- Renamed ScriptRuntimeFor* to ScriptProviderFor*
- Renamed SomeResolver to ScriptResolver.
- Broke SomeResolver.resolve method into a number of private methods
  to improve readability.
- Fixed problem with generation of filesystem URL.
- Removed ScriptContext.createContext method that took XScriptInfo as
  a parameter.
- Removed unused static boolean for JRE version number in PathUtils
Comment 3 noel.power 2003-09-24 08:04:49 UTC 
completed
Comment 4 joerg.skottke 2003-11-14 10:14:49 UTC 
developer bug.
verified.
Comment 5 noel.power 2005-01-06 15:24:34 UTC 
closed