Issue 21385 - References to dircmp obsolete?
Summary: References to dircmp obsolete?
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-17 23:07 UTC by quetschke
Modified: 2004-03-10 16:32 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-10-17 23:07:13 UTC 
While trying to fix issue 21201 I found a strage (to me) macro named
MY_DIRCMP=dircmp -r in sdk_oo/util/makefile.pmk. The ximian LXR showed me that
this macro is defined in:
 sdk_oo/util/makefile.pmk
 odk/util/makefile.pmk
And never used.

And 
api/odk/util/checkdiff.pl, line 64 -- # checkit - a perl script to check the
output of 'dircmp'
tools/solenv/bin/checkit.pl, line 2 -- # checkit - a perl script to check the
output of 'dircmp'
mention dircmp again. There are no further occurences.

Can I nuke the MY_DIRCMP macro and the checkit.pl?

CHECKSCRIPT=$(SOLARENV)$/bin$/checkit.pl is the only occurence of checkit.pl
and also not used.
Comment 1 quetschke 2003-10-17 23:07:37 UTC 
Set target
Comment 2 jsc 2003-10-20 10:38:19 UTC 
JSC: It seems that both macros are old and not longer used.
Comment 3 quetschke 2003-10-25 23:41:30 UTC 
vq->jsc: Was this a: "Yes, approved, please do." ?
Comment 4 hjs 2003-12-11 14:58:12 UTC 
i think it was but he never saw the question...
Comment 5 quetschke 2003-12-11 15:22:08 UTC 
Ok, next time I check the cc's ;-)

I take the issue then and fix it in ...fix2
Comment 6 quetschke 2003-12-20 16:45:38 UTC 
This is not a fix, but a code enhancement. I will try this on OOo 2.0 series.
Comment 7 quetschke 2004-02-18 01:45:50 UTC 
Committed to cws_src680_ooo20040225, resolving fixed.
Comment 8 quetschke 2004-02-23 19:44:59 UTC 
Oops, I just saw tin the tinderbox that odk/util/checkdiff.pl *IS* used.

I'll revert that change ASAP, that means this evening.

vq->ause: All occurences are used with "-" in the makefile command, i.e. no
error checking. Like this:

-diff -br $(DESTDIRIDL) $(SOLARIDLDIR) |& $(PERL) $(PRJ)$/util$/checkdiff.pl

Is there a special reason for the -? I didn't find the problem in my testbuild
because of this.
Comment 9 quetschke 2004-02-24 03:48:58 UTC 
Re-added odk/util/checkdiff.pl
Comment 10 quetschke 2004-02-26 22:33:35 UTC 
Resolve fixed
Comment 11 quetschke 2004-02-26 22:35:43 UTC 
Reopen to reassign ...
Comment 12 quetschke 2004-02-26 22:37:34 UTC 
vq->ause: Please verify

P.S.: Is there some special trick to reassign fixed issues?
Ho do you produce this NEW - FIXED issues?
Comment 13 hjs 2004-03-02 15:46:25 UTC 
AFAIK, "diff" returns an error code !=0 in case of differences.
NEW FIXED seems to result from reassigning fixed issues.

on first glance the changes look fine. and if it still builds, it was unused
;-). if juergen agrees, it's fine with me.
Comment 14 jens-heiner.rechtien 2004-03-02 16:46:03 UTC 
Fixed.
Comment 15 jens-heiner.rechtien 2004-03-02 16:46:17 UTC 
Verified.
Comment 16 hjs 2004-03-10 16:32:19 UTC 
.