Issue 26269 - OOo crashes if CUPS does not deliver a PPD
Summary: OOo crashes if CUPS does not deliver a PPD
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: ulf.stroehler
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-09 17:41 UTC by philipp.lohmann
Modified: 2010-11-10 17:11 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description philipp.lohmann 2004-03-09 17:41:57 UTC 
reported by Chris Halls:
Hi, I took the changes to cws_srx645_cups01 for a spin to see how the
code is doing.  I was very impressed with the added support - it works
nicely and I was able to modify my printer parameters within the Printer
Setup box and control my deskjet's draft/normal settings from within
OOo.

I did discover a problem, though.  I have a raw printer queue on my CUPS
server that does not have an associated PPD file.  If I select this
printer queue OOo crashes without warning.

A debug build of psprint indicates the problem:

cupsPrintFile found
cupsGetDests found
cupsSetDests found
cupsFreeDests found
cupsGetPPD found
cupsMarkOptions found
cupsAddOption found
cupsFreeOptions found
ppdOpenFile found
ppdClose found
cupsServer found
cupsUser found
cupsSetPasswordCB found
cupsSetUser found
found global defaults in
/usr/lib/openoffice/program/../share/psprint/psprint.conf
global settings: fontsubst = true, 8 substitutes
PPD for deskjet is /var/tmp/404dd05249d82
processing the following options for printer deskjet (instance (null)):
PPD for dj-raw is (null)
PPD for dj-raw is (null)
<crash>

So the 'deskjet' queue was fine, but 'dj-raw' has no PPD file.  Using
gdb I found problems during Init with calls to get the language level,
but even after that I had crashes in PPDParser::getKey.

So I don't think the workspace is ready for merging yet.

Thanks,
Chris
Comment 1 philipp.lohmann 2004-03-09 17:47:29 UTC 
pl->us: this might either be a follow-up or prevent cups01 from integration,
please decide
Comment 2 ulf.stroehler 2004-03-09 17:59:36 UTC 
Thanks Chris and Philipp.
I'd prefer fixing the raw queues before integration.
Comment 3 philipp.lohmann 2004-03-10 12:59:25 UTC 
fixed in CWS cups01

pl->us: for reproduction please add a deskjet to your local CUPS configuration
and switch of "local filtering" to get a raw queue.
Comment 4 philipp.lohmann 2004-03-10 12:59:49 UTC 
fixed
Comment 5 philipp.lohmann 2004-03-10 13:01:55 UTC 
us: please verify in CWS cups01
Comment 6 philipp.lohmann 2004-03-10 13:02:10 UTC 
fixed
Comment 7 ulf.stroehler 2004-03-10 15:51:17 UTC 
Reproduced issue and verified the fix in cws cups01.
Comment 8 ulf.stroehler 2004-03-10 15:54:15 UTC 
Changing Resolution to fixed in order to mark issue Verified.
Comment 9 ulf.stroehler 2004-03-10 15:55:15 UTC 
.
Comment 10 ulf.stroehler 2004-03-10 15:55:44 UTC 
Issue verified.
Comment 11 chris 2004-03-18 12:24:54 UTC 
Verified here too, many thanks!

Chris
Comment 12 ulf.stroehler 2004-08-19 18:22:25 UTC 
Re-verified on master workspace src680_m50.
Comment 13 dismetiner 2010-11-10 17:11:10 UTC 
Created attachment 73408