Issue 27541 - Word Import: new CustomShapeObj needs to be activated
Summary: Word Import: new CustomShapeObj needs to be activated
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: 680
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
: 34463 (view as issue list)
Depends on:
Blocks: 25448 29622
  Show dependency tree
 
Reported: 2004-04-07 08:21 UTC by sven.jacobi
Modified: 2013-08-07 14:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description sven.jacobi 2004-04-07 08:21:38 UTC
Hello Martin,
as I have heard you are now responsible for the Word import & export filter.

Depending to the Issues 20484 (AutoShapes), 20486 (3D Objects), 20485 (WordArt),
I20490 (grouping problem)  I have a short request. Up from src680m34 a new Shape
is available that is more compatible to the AutoShapes from Microsoft than
everything else we had before. The new shape is called SdrObjCustomShape. It is
now required that the Cumshape Object is activated also for the Word Import.

It's implementation can be found in :
svx/source/svdraw/svdoashp.cxx
svx/source/customshapes/*

At current only the PowerPoint import/export filter is using the new
CustomShapes and for compatibility reasons it is required that the Word & Excel
filter is doing also. I didn't activate CustomShapes for the Word&Excel filter,
because it was easier to integrate the feature for one application only, and of
course I didn't need to take care to the special treatment each application is
having (e.g. objects that are converted into fly frames or similar... ).

The export filter should automatically handle CustomShapes correctly, so only
the import filter needs to be adjusted by setting the
SVXMSDFF_SETTINGS_IMPORT_IAS flag at the SvxMSDffManager with something like that: 
   aSvxMSDffManager.SetSvxMSDffSettings(
       aSvxMSDffManager.GetSvxMSDffSettings()
          | SVXMSDFF_SETTINGS_IMPORT_IAS );

If the import of AutoShapes is activated, nearly each object will be imported as
SdrObjCustomShape, a exception of this rule is the SdrObjGraf and SdrOle2Obj,
thus also means that simple SdrRectObjs or SdrTextObjs won't occur any longer.

Internally each SdrObjCustomShape is derived from the SdrTextObj and adds
following features:
- text frame and shape frame is now strictly separated
- support of "wordwrap text in autoform"
- support of "resize autoform to fit text"
- no support of  "autogrow width" and "autogrow height"

If CustomShapes are loaded, the most important text attributes are already set
in the method:
DffPropertyReader::ApplyCustomShapeTextAttributes,
so it might be possible that some code of the virtual method ProcessObj can be
removed.

If you have any questions, wishes or enhancements than please contact me,
thanks,
Sven
Comment 1 andreas.martens 2004-06-16 16:33:50 UTC
.
Comment 2 andreas.martens 2004-07-30 10:56:47 UTC
The feature is already implemented. Now it's a defect that the import and export
doesn't use our new feature ;-)
Comment 3 michael.ruess 2004-08-24 13:45:21 UTC
added myself to cc ;-)
Comment 4 martin_maher 2004-08-31 14:06:35 UTC
mmaher: fixed in adare
Comment 5 michael.ruess 2004-09-22 08:11:44 UTC
*** Issue 34463 has been marked as a duplicate of this issue. ***
Comment 6 martin_maher 2004-10-19 15:06:34 UTC
Reopening to reassign
Comment 7 martin_maher 2004-10-19 15:07:24 UTC
reassigning to mru
Comment 8 martin_maher 2004-10-19 15:08:27 UTC
Fixed in adare
Comment 9 michael.ruess 2004-10-28 09:20:16 UTC
Verified fix in CWS adarefilterteam29.
Comment 10 michael.ruess 2004-11-05 13:53:32 UTC
Checked integration in 680m60.