Issue 27818 - Rebuild fails in odk (zip return value !=0)
Summary: Rebuild fails in odk (zip return value !=0)
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: PC Windows 2000
: P3 Trivial
Target Milestone: ---
Assignee: jsc
QA Contact: issues@api
URL:
Keywords:
Depends on:
Blocks: 18562
  Show dependency tree
 
Reported: 2004-04-15 01:59 UTC by quetschke
Modified: 2013-02-24 21:09 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2004-04-15 01:59:40 UTC 
When issue 18652 is fixed, the rebuild of odk fails with:

/cygdrive/d/v1/cws_srx645_ooo112fix1/odk/util
cd ../wntmsci8.pro/bin && guw.pl zip -urq odk645.zip odk645
Command: zip
dmake:  Error code 12, while making '../wntmsci8.pro/bin/odk645.zip'
echo: No match.

ERROR: Error 65280 occurred while making
/cygdrive/d/v1/cws_srx645_ooo112fix1/odk/util
dmake:  Error code 1, while making 'build_all'

I can remember I fixed the same error before? The problem is the return value
of zip, when it does nothing (everything is up-to-date). The following patch
fixes this.

--- odk/util/makefile.mk	9 Jan 2004 18:02:11 -0000	1.17.12.1
+++ odk/util/makefile.mk	15 Apr 2004 00:02:06 -0000
@@ -16,7 +16,8 @@
 .ENDIF
 
 $(BIN)$/$(PRODUCTZIPFILE) : $(SDK_CONTENT_CHECK_FILES) $(SDKCHECKFLAG)
-	+cd $(BIN) && $(WRAPCMD) zip -urq $(PRODUCTZIPFILE) $(PRODUCT_NAME)
+	+-cd $(BIN) && $(WRAPCMD) zip -urq $(PRODUCTZIPFILE) $(PRODUCT_NAME)
+#	zip returns errorlevel !=0 when it does nothing. (rebuild)
 
 $(BIN)$/$(PRODUCTTARGZFILE) : $(SDK_CONTENT_CHECK_FILES) $(SDKCHECKFLAG)
 	+-rm -f $@ >& $(NULLDEV)
Comment 1 quetschke 2004-04-15 02:01:05 UTC 
This issue blocks 18652

(With both patches I can build odk again and again)
Comment 2 quetschke 2004-04-15 02:02:27 UTC 
Argh, I meant issue 18562.
Comment 3 quetschke 2004-04-15 02:02:47 UTC 
Argh, I meant issue 18562.
Comment 4 quetschke 2004-04-20 00:56:34 UTC 
Committed to cws_srx645_ooo112fix1.
Comment 5 sander_traveling 2004-04-28 19:29:04 UTC 
set as verified
Comment 6 sander_traveling 2004-04-28 19:29:34 UTC 
closing