Issue 28720 - Parameters not allowed for external programs
Summary: Parameters not allowed for external programs
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.1.1
Hardware: All Linux, all
: P3 Trivial with 1 vote (vote)
Target Milestone: OOo 1.1.3
Assignee: nospam4obr
QA Contact: issues@gsl
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2004-05-04 14:59 UTC by kendy
Modified: 2006-04-27 20:37 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Proposed patch (allow parameters for external programs) (1.67 KB, patch)
2004-05-04 15:01 UTC, kendy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description kendy 2004-05-04 14:59:50 UTC
The value of 
Tools->Options->OpenOffice.org->External programs->(HTTP|HTTPS|FTP|MAILTO) 
is treated just like a program name without parameters. This is not sufficient 
in KDE, where "kfmclient exec URL" is necessary to work properly. When 
"kfmclient exec" is entered in the dialog, the execution fails, because the 
input is treated as the space is a part of the filename. It is a very rare 
case I guess, so I propose the attached patch.
Comment 1 kendy 2004-05-04 15:01:35 UTC
Created attachment 14966 [details]
Proposed patch (allow parameters for external programs)
Comment 2 flibby05 2004-05-04 17:07:05 UTC
Hi kendy,
  thanks for using and supporting OpenOffice.Org!

@ cp: clear description + proposed patch, set to "NEW"
Comment 3 nospam4obr 2004-05-05 10:45:15 UTC
The patch will be obsolete as soon as CWS defaultbrowser is integrated.
Comment 4 kendy 2004-05-05 12:29:01 UTC
Still, I'd like to use the feature in the 1.1.x codeline... 
I'd like to reopen the issue (sorry! :) ), but I do not have rights to do 
that. 
Comment 5 nospam4obr 2004-05-05 12:43:22 UTC
Reopened. Sorry for the confusion.
Comment 6 christof.pintaske 2004-05-07 12:00:54 UTC
but why me ?
Comment 7 nospam4obr 2004-05-10 06:46:30 UTC
I am a bit concerned your patch might break launching apps with blanks in their
name/path. On the other hand I  am not aware of any browser with blanks in it's
name, so you commiting your patch should be safe. Did releases@ approve this one
for 1.1.2 ?
Comment 8 nospam4obr 2004-06-04 13:35:28 UTC
Target 1.1.3 approved by MH and ATR.
Comment 9 dmladek 2004-06-29 09:10:06 UTC
CC'ing myself
Comment 10 dmladek 2004-06-29 09:20:46 UTC
I don't know the current state of this issue, but I need I could execute
External programs as follows:

-for HTTP: /opt/mozilla.org/firefox/firefox -remote "openURL(%s, new-tab)"
 
  or via shell script, eg: ~/bin/firefox-remote
  where its content is like:
   #!/bin/sh
   /opt/mozilla.org/firefox/firefox -remote "openURL($1,new-tab)"

-for MAILTO: /opt/mozilla.org/thunderbird/thunderbird -remote "mailto (%s )"

more details how to invoke new Window/TAB using already running instance of
Mozilla Mail-ThunderBird/Browser-FireFox Clients are at this URL:
http://www.mozilla.org/unix/remote.html


Well, I found in OOo.forum a discussion at URL:
http://www.oooforum.org/forum/viewtopic.php?p=38475
There's someone "Guest" complains and later find a working way
when a user use her script to invoke new FireFox Tab.

But it doesn't work for me :-(
I'm using Staroffice 7.0 and RedHat FedoraCore 1


Comment 11 nospam4obr 2004-06-29 13:59:00 UTC
The script seems to assume that firefox is already running. Actually you have to
test this using the 'ping' command before you know which command line to use.

This is all fixed on the SRC680 branch ..
Comment 12 dmladek 2004-06-30 06:27:36 UTC
Yes I assume that firefox is already running (and I usualy runs it whole my
session at PC:). But with ping command it's good hint to make it more clever"
Comment 13 nospam4obr 2004-07-12 13:02:47 UTC
So we have two options:

1) Applying the patch as it is
2) Backport the more general solution from SRC680

What do you think ?
Comment 14 nospam4obr 2004-07-15 09:28:34 UTC
On a second thought: backporting the SRC680 solution involves UI changes, so
this is not really an option.
Comment 15 nospam4obr 2004-07-28 07:29:20 UTC
Patch applied on CWS ooo113fix2.
Comment 16 Martin Hollmichel 2004-08-26 14:13:35 UTC
verified.
Comment 17 nospam4obr 2006-04-27 20:37:06 UTC
closing.