Issue 30887 - dmake: Inconsistent license headers and copyrights
Summary: dmake: Inconsistent license headers and copyrights
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: Martin Hollmichel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-29 19:21 UTC by quetschke
Modified: 2004-12-20 15:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Proposal for correcting the license headers. (4.25 KB, patch)
2004-07-08 23:53 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2004-06-29 19:21:28 UTC
The following files in the dmake directory have the standard LGPL/SISSL header
just above this info:

-- COPYRIGHT
--      Copyright (c) 1996,1997 by WTI Corp.  All rights reserved.
-- 
--      This program is NOT free software; you can redistribute it and/or
--      modify it under the terms of the Software License Agreement Provided
--      in the file <distribution-root>/readme/license.txt.

-----------------------------------------------^^^^^^^^^^^ this is a
GNU GENERAL PUBLIC LICENSE, Version 1, February 1989

Makefile.am, Makefile.in, dag.c,
dmake.c, expand.c, extern.h,
function.c, infer.c, make.c,
parse.c, quit.c, rulparse.c,
stdmacs.h, unix/arlib.c, unix/dcache.c,
unix/rmprq.c, unix/ruletab.c, unix/runargv.c,
unix/cygwin/conf.h, unix/cygwin/public.h,
unix/linux/gnu/public.h, unix/solaris/conf.h,
win95/microsft/config.h

This is propably a mistake and should be replaced by something like:

-- $RCSfile: xxx.c,v $
-- $Revision: 1.3 $
-- last change: $Author: yy $ $Date: 2003/03/25 14:02:10 $
--
-- COPYRIGHT
--      Copyright (c) 1996,1997 by WTI Corp.  All rights reserved.
--      Copyright (c) 2004 by Sun Microsystems, Inc.  All rights reserved.
-- 
--      This program is NOT free software; you can redistribute it and/or
--      modify it under the terms of the Software License Agreement Provided
--      in the file <distribution-root>/readme/license.txt.
Comment 1 Martin Hollmichel 2004-06-30 08:23:22 UTC
hmmm, I'm also wondering who was the guy, who added the LGPL/SISSL header on
2003/02/11 :).

dmake is and was GPL licensed and is not part of the OOo product. but indeed the
copyright is misleading. WTI Corp once decided to GPL their dmake source and
didn't change all the copyright header but only the
<distribution-root>/readme/license.txt. 
We should add a header which does make a clear statement.
Comment 2 quetschke 2004-06-30 14:08:15 UTC
> hmmm, I'm also wondering who was the guy, who added the LGPL/SISSL header
> on 2003/02/11 :).
Hmm, you mean the guy who blindly merged the changes that were done on
2003-01-17 05:24:34-0700 on another branch ;-) .

And the Makefile.* are new, so LGPL/SISSL is propably OK for them.
Comment 3 quetschke 2004-07-08 23:53:37 UTC
Created attachment 16337 [details]
Proposal for correcting the license headers.
Comment 4 quetschke 2004-07-09 00:01:05 UTC
vq->mh: The previous patch is a proposal of the handling of the license headers.
Can you please say (find out) if the adding of the Sun Copyright is correct:
---      Copyright (c) 1996,1997 by WTI Corp.  All rights reserved.
+--      Copyright (c) 1996,1997 by WTI Corp.
+--      Copyright (c) 2004 by by Sun Microsystems, Inc.
The copyright should mention every year when the file was touched, at least gcc
does it that way. (Lets start with the current year)

And is it OK to remove the WWW part?
--- WWW
---      http://dmake.wticorp.com/
---

If the changes are accepted I'll prepare a patch for all files with license
problems.
Comment 5 quetschke 2004-07-15 23:29:33 UTC
I removed the LGPL/SISSL headers in cws_src680_ooo20040704.

Except from
  dmake/Makefile.am
  dmake/Makefile.in
  dmake/unix/cygwin/conf.h (see below)
  dmake/unix/cygwin/public.h
because these are files that are added after the initial import of dmake into cvs.

But the problem with the copyright and the text below remains.

I also removed dmake/unix/cygwin/conf.h because it is not needed anymore.
Comment 6 vg 2004-08-24 11:46:01 UTC
Please, set the bug to "fixed" or at least "worksforme"
Comment 7 quetschke 2004-08-24 15:54:23 UTC
Oops, that happens when I commit things to issues that are not mine.

But I was still hoping for an answer for this:

vq->mh:Can you please say (find out) if the adding of the Sun Copyright is correct:
---      Copyright (c) 1996,1997 by WTI Corp.  All rights reserved.
+--      Copyright (c) 1996,1997 by WTI Corp.
+--      Copyright (c) 2004 by by Sun Microsystems, Inc.
The copyright should mention every year when the file was touched, at least gcc
does it that way. (Lets start with the current year)
Comment 8 Martin Hollmichel 2004-12-20 15:45:29 UTC
close issue.