Issue 31033 - Value never assigned.
Summary: Value never assigned.
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: philipp.lohmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks: 30874
  Show dependency tree
 
Reported: 2004-07-02 13:51 UTC by foskey
Modified: 2004-09-10 12:24 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2004-07-02 13:51:42 UTC 
vcl/unx/source/app/i18n_wrp.cxx

The Variable s is defined but never assigned, then returned.

Status XvaCloseIM(XIM im)
{
  	Status s;

	/* MacOS X doesn't yet support XIM... FIXME */
#if !defined(MACOSX)  
	if (!g_dlmodule) 
	{		
		/* assuming one XvaOpenIM call */
    	dlclose(g_dlmodule);
   	 	g_dlmodule = (void*)0;
    	g_open_im = (OpenFunction)NULL;
  	}
#endif
	return (s);
}
Comment 1 foskey 2004-07-02 13:56:53 UTC 
Same directory sunconvert.cxx the value a2p is not assigned.  Here is my rough
patch.  I have no idea what the correct value of a2p should be.

--- sunconvert.cxx      6 Jan 2004 14:35:26 -0000       1.2
+++ sunconvert.cxx      2 Jul 2004 12:55:14 -0000
@@ -691,6 +691,8 @@
                state_ptr->b[3] = 0;
                state_ptr->b[4] = 0;
                state_ptr->b[5] = 0;
+               // TODO WHat is the correct value of a2p
+               a2p = 0;
        } else {                        /* update a's and b's */
                pks1 = pk0 ^ state_ptr->pk[0];          /* UPA2 */
Comment 2 christof.pintaske 2004-07-12 16:42:53 UTC 
cp->pl: I think you have fixed the issue with sunconvert already, please have a
look. 

XVaCloseIM() isn't used, and the (XCloseIM-) man page doesn't specify the status
at all. However we should get rid of the warning as it is trivial (Status is an
int ...). Could you accomodate with that ?
Comment 3 philipp.lohmann 2004-07-14 17:09:07 UTC 
fixed in CWS vcl25
Comment 4 philipp.lohmann 2004-08-03 15:47:42 UTC 
verified in CWS vcl25
Comment 5 philipp.lohmann 2004-09-10 12:24:44 UTC 
merged in 680m54