Created attachment 16265 [details]
Patch for cws tooling

dispatch to Heiner

Committed to CWS hr5

Close.

Hi Heiner,

you deviated a bit from fix to:
----
BEGIN {
    if ( !defined($ENV{SOLARENV}) ) {
        die "No environment found (environment variable SOLARENV is undefined)";
    }
    push(@lib_dirs, "$ENV{SOLARENV}/bin/modules");
    push(@lib_dirs, "$ENV{COMMON_ENV_TOOLS}/modules") if
defined($ENV{COMMON_ENV_TOOLS});
}
----
The difference is the order of SOLARENV and COMMON_ENV_TOOLS. I put
COMMON_ENV_TOOLS in front of SOLENV on purpose. This allows me to override
the checked out cws tools in SOLENV and use the ones chosen by COMMON_ENV_TOOLS.

Was this done on purpose or would you accept a patch to change to the order?

Volker

I meant:

> you deviated a bit from fix to:
-------  my  ------------^ 

Hi Volker,

placing COMMON_ENV_TOOLS before SOLAR_ENV brakes the Hamburg build environment.
It's also logically not quite correct, because a workspace specific directory
like SOLAR_ENV should override a more general directory COMMON_ENV_TOOLS which
is meant serving all workspaces. This way we can make enhancements to the tools
without breaking all the old workspaces. The main problem is that we (that's
Hamburg RE) have several live workspaces online which all need to be active at
the same time - talk about the pain of always being able to create patches to 5
year old releases ... :-) 

Hi Heiner,

you're right. This way one can work in a cws to fix the tools, but I stepped
into this problem with cws 0815 where your patches for the cwstools are not
applied yet and they overrode my HEAD checkout in COMMON_ENV_TOOLS.

But time will solve this problem, newer milestones should work OK ;)

This issue is integrated into a build for OOo2.0, but the 'target milestone'
isn't set. To have a better overview about all fixed and integrated tasks in
OOo2.0, I set the field 'target milestone' to OOo2.0.