Apache OpenOffice (AOO) Bugzilla – Issue 3158
ooo1.0 scp/source/lingu is old needs to be updated for lingucomponent
Last modified: 2003-09-08 16:53:51 UTC
scp/source/lingu which installs the lingucomponent pieces that include the spellchecker thesaurus and hyphenator is old and needs to be updated. The version in OOO_STABLE_1 still references aspell which has not been used for some time now (around OO638). I will attach patch that properly updates scp/source/lingu for the lingucomponent project. basically this patch brings scp/source/lingu to what it was for OO641C plus a few minor corrections. Thanks, Kevin
Created attachment 1074 [details] patch to scp/source/lingu to make it work with lingucomponent
add patch and mark with proper ooo1.0 keyword
Hi Sander, is this for you? If not, please forward.
what the status of review, if you're unsure let review by Ingo (is@openoffice.org).
Hi, If it matters earlier versions of this patch have been in every release tree since OO638 when we rolled out myspell. This change will only impact the lingucomponent module which I am the owner of and needs to be present for Spellchecking and Thesaurus to work at all under OOo. Hope this info helps, Kevin
Hi, May I please get a final arbitration on this patch. Without it OOO_STABLE_1 will not have a working Spellchecker in any language. Earlier versions of this patch have been in every tree since MySpell was introduced. Thanks, Kevin
Hi Kevin, your changes look good. One thing I do not know is, if you want your new files belong to the lingu module or to the root. For example the new GID_FILE_LIB_SPELL is not added to the file list of the lingu module. Therefore it will be installed always. Another nice thing is, if you also change the scp/inc/gid.inc in which you define the new gids in lower cases, like gid_File_Lib_Spell Anything else of your changes look good. Greetings Ingo
(As Ingo might miss the mail reply I add Kevin's comments to the issue) Kevin wrote: Yes, it should always be installed since it supports multiple language spellchecking. The thesaurus is only en_US but it is the only one we have so it should probably always be installed also, + Another nice thing is, if you also change the scp/inc/gid.inc in + which you define the new gids in lower cases, like + gid_File_Lib_Spell Whoops forgot about that. They are already in my own tree, I just forgot to diff it against the one from OOO_STABLE_1. So I will change scp/inc/gid.inc and remove the old defines for the aspell and pspell items and replace them with the curent ones.. FYI: There will also be another patch coming soon from Peter (the author of the OOo lingucomponent hyphenator, that will also impact just the scp/source/lingu module (and of course will include defines in scp/inc/gid.inc as well). Will you need to review that patch as well or is it okay since it will only impact scp/source/lingu in the OOo builds (not Star related at all).
Hi Kevin, I think you can make the changes in the lingu module without my review. Nevertheless I would like to know about the final structure of the lingu module because I make some greater changes in the scp project and want to include your changes. Greetings Ingo
Hi, I made the commits to both scp/source/lingu and the scp/inc/gid.inc so we can close this one. Further changes to scp/source/lingu and gid.inc will be required to support Peter's Hyphenator but we will open a new Issue for that when Peter has a patch ready. Thanks, Kevin
closing this one.