Issue 32386 - Autocorrect files and ISO codes?
Summary: Autocorrect files and ISO codes?
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: 680m49
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: tom
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-31 20:39 UTC by pavel
Modified: 2013-08-07 15:00 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-07-31 20:39:03 UTC 
Hi,

autocorrect files, ie.

extras/source/autotext/lang/pt-BR/acor1046.dat

contain the MS LCID codes in their names. What about using ISO codes instead in
2.0 so we reduce the "another-naming-scheme-for-localized-files"?
Comment 1 ooo 2004-08-03 12:45:43 UTC 
From a first glance there is only one code place to change:

svx/source/editeng/svxacorr.cxx method SvxAutoCorrect::GetAutoCorrFileName()
should simply use ConvertLanguageToIsoString(eLang) instead of
String::CreateFromInt32(eLang)

The old offmgr code is gone, and also setup2 will be removed for OOo2.0, though
a native setup will have to handle these files as well, of course.

Cc'ing Oliver Specht on this, since he's the owner of AutoCorrection.

Tom, Oliver: feasible for OOo2.0?
Comment 2 Oliver Specht 2004-08-09 09:38:44 UTC 
os: No problem with me
Comment 3 tom 2004-08-11 13:13:29 UTC 
OK, let's do it.
Comment 4 pavel 2004-08-11 18:06:17 UTC 
tv: I'd like to suggest one more unification. autocorr directory in the
installed OOo doesn't contain directories like en, cs, ..., but all files in the
same directory:

pavel@pavel:~/OpenOffice.org680/share/autocorr> ls -1
acor1033.dat
acor2057.dat

Other directories, like template, samples, autotext and wordbook contain such
directories. What about unifying it too? Should be almost trivial and it would
also make OOo source unified - all autocorr files will be named the same in
separate language dependent directory - named according to ISO codes.
Comment 5 Oliver Specht 2004-08-12 07:45:19 UTC 
->pjanik: The difference to templates and samples is that you may have
autocorrection files for more than the installation language. You would end up
having tons of directories each containing one file.
Comment 6 pavel 2004-08-12 08:17:19 UTC 
os: right. Maybe in the future, we will support more autocorr files. But you are
right. It is not needed right now. I primarily wanted to have the same structure
for extras/... in the sources.
Comment 7 Oliver Specht 2004-08-12 08:30:44 UTC 
We do support more autocorr files already. 
They are not installed but they are created once you use the AutoCorrect dialog
with a different language selection.
Comment 8 ooo 2004-08-16 11:32:01 UTC 
Oliver, Tom,

For cosmetical reasons I suggest to insert an underscore before the locale
string, so the file name would be acor_en-US.dat, for example. Doing so might
also help in not accidentally generating names that have some questionable
meaning in one or the other language..

Eike
Comment 9 tom 2004-08-25 10:36:47 UTC 
TV: Good idea, Eike. Lets make it so if Oliver does not object.
Comment 10 tom 2005-01-14 17:10:46 UTC 
TV: fixed in CWS extras16
Comment 11 tom 2005-01-20 09:24:04 UTC 
TV: verified ok in CWS extras16.
Comment 12 tom 2005-02-14 11:59:09 UTC 
TV: Its in the master and ok -> closed