Apache OpenOffice (AOO) Bugzilla – Issue 32647
Basque patches for i18npool module
Last modified: 2013-08-07 15:00:08 UTC
Cloned task for *** Issue 31644 *** with target milestone: OOo 1.1.3
Hi Larranaga, For OOo2.0 we'll need a slightly different eu.xml locale data file than the one provided for OOo1.1.3. A new section LC_INDEX has to be added, see http://l10n.openoffice.org/servlets/ReadMsg?list=features&msgNo=16 and a recent i18npool/source/localedata/data/locale.dtd, and for example other *.xml. Please attach a unified diff against the revision already checked-in for OOo1.1.3. When done, please reassign this issue to me. Thanks Eike
Hi Dooteo, As a reminder: we need the locale data until end of September / beginning of October. Otherwise I will add the LC_INDEX section of en_US, which might not be sufficient for your locale. Thanks Eike
Created attachment 17526 [details] i18npool module's basque locale data
Hi Eike, Please, can you check eu.xml file? I'd check it using Mozzila, and there is not XML sintax errors. I didn't build OOo 680 milestone, just download OOo from CVS and update this file. Thanks and regards, Dooteo
Hi Dooteo, Please, if files are already checked in to CVS, always submit patches generated by a diff -u command against the latest revision (or a specific revision in question, if any), this allows to apply the diff in most cases without having to figure out which changes might have been in between. Though I must admit that doing a diff across branches against a revision in the Attic isn't that obvious if one isn't acquainted with CVS. I'll atach the resulting diff for illustration. There sneaked in at least one error that doubles a closing angle bracket: -<FormatCode>NN YYYY/MMM/DD</FormatCode> +<FormatCode>>NN YYYY/MMM/DD</FormatCode> And an OutLineNumberingLevel has a Suffix=" " replaced with Suffix=")" Was this on purpose? -<OutLineNumberingLevel Prefix=" " NumType="6" Suffix=" " BulletChar="E004" BulletFontName="StarSymbol" ParentNumbering="0" LeftMargin="100" SymbolTextDistance="50" FirstLineOffset="0" /> +<OutLineNumberingLevel Prefix=" " NumType="6" Suffix=")" BulletChar="E004" BulletFontName="StarSymbol" ParentNumbering="0" LeftMargin="100" SymbolTextDistance="50" FirstLineOffset="0" /> Eike
Created attachment 17534 [details] diff against -r1.1.4.1 eu.xml of attachment above
Hi Eike, Last night I updated my local CVS and I see eu.xml.diff is not applied. That's okey. On the next diff I'm gonna submit to issuezilla will be apply over it: There is not lines like (so typo mistake is fixed): -<FormatCode>NN YYYY/MMM/DD</FormatCode> +<FormatCode>>NN YYYY/MMM/DD</FormatCode> > And an OutLineNumberingLevel has a Suffix=" " replaced with Suffix=")" > Was this on purpose? The is a really old reason. It cames (Suffix=" ") from OOo 1.0.2 version, so it is time to be fixed too. Looking to other *_xml files, I think the best way it's to make these tags (LC_NumberingLevel and LC_OutLineNumberingLevel) refer to "en_US" instead to be a copy of them... (...) -<OutLineNumberingLevel Prefix=" " NumType="6" Suffix=" " BulletChar="2022" BulletFontName="StarSymbol" ParentNumbering="0" LeftMargin="200" SymbolTextDistance="50" FirstLineOffset="0" /> -</OutlineStyle> -</LC_OutLineNumberingLevel> +<LC_NumberingLevel ref="en_US"/> +<LC_OutLineNumberingLevel ref="en_US"/> Eike, can you apply the second eu.xml.diff (dated as 10 Sep 2004) over CVS's eu.xml file? Thanks and regards, Dooteo
Created attachment 17641 [details] apply this diff against -r1.1.4.1 eu.xml of attachment above
Hi Dooteo, Apply a diff against a file that should have been a diff against an already checked in version.. well, I will sort that out somehow ;-) not a real problem. And yes, if the NumberingLevel sections are identical to the en_US ones, they should simply refer to it. Note that this issue was added to CWS localedatafixes, http://eis.services.openoffice.org/EIS2/servlet/cws.ShowCWS?Id=1400&Path=SRC680%2Flocaledatafixes so the patch will not appear in CVS HEAD before that CWS is integrated. Eike
Grabbing issue.
Grabbing issue, I said.
On branch cws_src680_localedatafixes: i18npool/source/localedata/localedata.cxx 1.28.16.1 i18npool/source/localedata/data/eu.xml 1.1.6.1 i18npool/source/localedata/data/localedata_euro.map 1.8.18.1 i18npool/source/localedata/data/makefile.mk 1.24.18.1
Reopen to reassign.
Reassign to QA.
Restore status.
tk: Verified on branch cws_src680_localedatafixes
closed because fix available in OOo1.9m62