Issue 32647 - Basque patches for i18npool module
Summary: Basque patches for i18npool module
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-05 18:36 UTC by ooo
Modified: 2013-08-07 15:00 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
i18npool module's basque locale data (21.91 KB, text/xml)
2004-09-03 10:58 UTC, dooteo
no flags Details
diff against -r1.1.4.1 eu.xml of attachment above (4.89 KB, patch)
2004-09-03 13:41 UTC, ooo
no flags Details | Diff
apply this diff against -r1.1.4.1 eu.xml of attachment above (11.27 KB, text/plain)
2004-09-10 08:34 UTC, dooteo
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description ooo 2004-08-05 18:36:26 UTC
Cloned task for *** Issue 31644 *** with target milestone: OOo 1.1.3
Comment 1 ooo 2004-08-05 18:43:50 UTC
Hi Larranaga,

For OOo2.0 we'll need a slightly different eu.xml locale data file than the
one provided for OOo1.1.3. A new section LC_INDEX has to be added, see
http://l10n.openoffice.org/servlets/ReadMsg?list=features&msgNo=16 and a recent
i18npool/source/localedata/data/locale.dtd, and for example other *.xml. Please
attach a unified diff against the revision already checked-in for OOo1.1.3.  When
done, please reassign this issue to me.

Thanks
Eike
Comment 2 ooo 2004-09-02 10:30:25 UTC
Hi Dooteo,

As a reminder: we need the locale data until end of September / beginning of
October. Otherwise I will add the LC_INDEX section of en_US, which might not be
sufficient for your locale.

Thanks
Eike
Comment 3 dooteo 2004-09-03 10:58:37 UTC
Created attachment 17526 [details]
i18npool module's basque locale data
Comment 4 dooteo 2004-09-03 11:02:39 UTC
Hi Eike,

Please, can you check eu.xml file? I'd check it using Mozzila, and there is not
XML sintax errors. I didn't build OOo 680 milestone, just download OOo from CVS
and update this file.

Thanks and regards,

Dooteo
Comment 5 ooo 2004-09-03 13:37:09 UTC
Hi Dooteo,

Please, if files are already checked in to CVS, always submit patches generated
by a diff -u command against the latest revision (or a specific revision in
question, if any), this allows to apply the diff in most cases without having to
figure out which changes might have been in between. Though I must admit that
doing a diff across branches against a revision in the Attic isn't that obvious
if one isn't acquainted with CVS. I'll atach the resulting diff for illustration.

There sneaked in at least one error that doubles a closing angle bracket:
-<FormatCode>NN YYYY/MMM/DD</FormatCode>
+<FormatCode>>NN YYYY/MMM/DD</FormatCode>

And an OutLineNumberingLevel has a Suffix=" " replaced with Suffix=")"
Was this on purpose?
-<OutLineNumberingLevel Prefix=" " NumType="6" Suffix=" " BulletChar="E004" 
BulletFontName="StarSymbol"  ParentNumbering="0" LeftMargin="100"
SymbolTextDistance="50" FirstLineOffset="0" />
+<OutLineNumberingLevel Prefix=" " NumType="6" Suffix=")" BulletChar="E004" 
BulletFontName="StarSymbol"  ParentNumbering="0" LeftMargin="100"
SymbolTextDistance="50" FirstLineOffset="0" />


Eike
Comment 6 ooo 2004-09-03 13:41:42 UTC
Created attachment 17534 [details]
diff against -r1.1.4.1 eu.xml of attachment above
Comment 7 dooteo 2004-09-10 08:30:43 UTC
Hi Eike,

Last night I updated my local CVS and I see eu.xml.diff is not applied. That's
okey. On the next diff I'm gonna submit to issuezilla will be apply over it:

There is not lines like (so typo mistake is fixed):
  -<FormatCode>NN YYYY/MMM/DD</FormatCode>
  +<FormatCode>>NN YYYY/MMM/DD</FormatCode>


> And an OutLineNumberingLevel has a Suffix=" " replaced with Suffix=")"
> Was this on purpose?

The is a really old reason. It cames (Suffix=" ") from OOo 1.0.2 version, so it
is time to be fixed too. Looking to other *_xml files, I think the best way it's
to make these tags (LC_NumberingLevel and LC_OutLineNumberingLevel) refer to
"en_US" instead to be a copy of them...

(...)
  -<OutLineNumberingLevel Prefix=" " NumType="6" Suffix=" " BulletChar="2022"
BulletFontName="StarSymbol"  ParentNumbering="0" LeftMargin="200"
SymbolTextDistance="50" FirstLineOffset="0" />
  -</OutlineStyle>
  -</LC_OutLineNumberingLevel>
  +<LC_NumberingLevel ref="en_US"/>
  +<LC_OutLineNumberingLevel ref="en_US"/>

Eike, can you apply the second eu.xml.diff (dated as 10 
Sep 2004) over CVS's eu.xml file?

Thanks and regards,

Dooteo
Comment 8 dooteo 2004-09-10 08:34:50 UTC
Created attachment 17641 [details]
apply this diff against -r1.1.4.1 eu.xml of attachment above
Comment 9 ooo 2004-09-13 10:32:16 UTC
Hi Dooteo,

Apply a diff against a file that should have been a diff against an already
checked in version.. well, I will sort that out somehow ;-)  not a real problem.
And yes, if the NumberingLevel sections are identical to the en_US ones, they
should simply refer to it.

Note that this issue was added to CWS localedatafixes,
http://eis.services.openoffice.org/EIS2/servlet/cws.ShowCWS?Id=1400&Path=SRC680%2Flocaledatafixes
so the patch will not appear in CVS HEAD before that CWS is integrated.

Eike
Comment 10 ooo 2004-10-27 16:17:52 UTC
Grabbing issue.
Comment 11 ooo 2004-10-27 16:18:37 UTC
Grabbing issue, I said.
Comment 12 ooo 2004-10-27 16:21:30 UTC
On branch cws_src680_localedatafixes:
i18npool/source/localedata/localedata.cxx 1.28.16.1
i18npool/source/localedata/data/eu.xml 1.1.6.1
i18npool/source/localedata/data/localedata_euro.map 1.8.18.1
i18npool/source/localedata/data/makefile.mk 1.24.18.1
Comment 13 ooo 2004-11-03 14:07:33 UTC
Reopen to reassign.
Comment 14 ooo 2004-11-03 14:29:11 UTC
Reassign to QA.
Comment 15 ooo 2004-11-03 14:31:57 UTC
Restore status.
Comment 16 kla 2004-11-08 13:01:59 UTC
tk: Verified on branch cws_src680_localedatafixes
Comment 17 oc 2004-11-23 13:40:19 UTC
closed because fix available in OOo1.9m62