Issue 32706 - binfilter: duplicate identifiers
Summary: binfilter: duplicate identifiers
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: Armin Le Grand
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-07 10:11 UTC by pavel
Modified: 2004-09-09 17:52 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-08-07 10:11:28 UTC 
Hi,

oo@oo:~/BuildDir/ooo_SRC680_m50_src/binfilter> grep
ERRCODE_SVX_GRAPHIC_WRONG_FILEFORMAT bf_svx/source/items/svx_svxerr.src
        String ERRCODE_SVX_GRAPHIC_WRONG_FILEFORMAT&ERRCODE_RES_MASK
String ERRCODE_SVX_GRAPHIC_WRONG_FILEFORMAT&ERRCODE_RES_MASK

Thus:

Preprocessor commandline:  -I. -I. -I. -I../inc -I../../../inc
-I../../../inc/bf_svx -I../../../unx/inc -I../../../unxlngi4.pro/inc -I.
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solver/680/unxlngi4.pro/inc/stl
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solver/680/unxlngi4.pro/inc/external
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solver/680/unxlngi4.pro/inc
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solenv/unxlngi4/inc
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solenv/inc
-I/home/oo/BuildDir/ooo_SRC680_m50_src/res
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solver/680/unxlngi4.pro/inc/stl
-I/home/oo/BuildDir/ooo_SRC680_m50_src/solenv/inc/Xp31
-I/usr/lib/SunJava2/include -I/usr/lib/SunJava2/include/linux
-I/usr/lib/SunJava2/include/native_threads/include -I/usr/X11R6/include -I.
-I../../../res -I. -DUNX -DVCL -DGCC -DC300 -DSUPD=680 -DSOLAR_JAVA
-DBUILD_SPECIAL= -DPRODUCT -DPRODUCT_FULL -DNDEBUG -DOSL_DEBUG_LEVEL=0
-DUPDVER="680" ../../../unxlngi4.pro/misc/svx_items/svx_svxitems.src /tmp/zHNBNz
Preprocessor startline:  rscpp @/tmp/1aETYK
Rsc2 commandline: rsc2 @/tmp/F8Jn0U
Files: /tmp/PQ2qph /tmp/zHNBNz 
reading file /tmp/Q2Rw3n ..
TEXT = "Eine unverknüpfte Grafik konnte nicht geladen werden" ;
^
f4104: "../../../unxlngi4.pro/misc/svx_items/svx_svxerr.src", line 553: Warning
in the object (Type: String, 2824):
Two local resources have the same identifier.

TEXT [ English ] = "An embedded graphic could not be read" ;
              ^
f640: "../../../unxlngi4.pro/misc/svx_items/svx_svxerr.src", line 554: Error:
syntax error

f256: Error: !! 1 Error found!!
Error starting rsc2 compiler
dmake:  Error code 1, while making '../../../unxlngi4.pro/srs/svx_svxitems.srs'
Comment 1 pavel 2004-08-07 10:12:03 UTC 
set target.
Comment 2 pavel 2004-08-07 13:44:33 UTC 
Ivo: those two Strings contain the same strings. The first one contains:

        String ERRCODE_SVX_GRAPHIC_WRONG_FILEFORMAT&ERRCODE_RES_MASK
        {
                Text [ de ] = "Eine unverknüpfte Grafik konnte nicht geladen
werden" ;

Ie. it already uses ISO codes. The second one:

String ERRCODE_SVX_GRAPHIC_WRONG_FILEFORMAT&ERRCODE_RES_MASK
{
        TEXT = "Eine unverknüpfte Grafik konnte nicht geladen werden" ;
        TEXT [ English ] = "An embedded graphic could not be read" ;

Shouldn't be the second one commented with //STRIP001 as others already are?
Comment 3 mci 2004-08-09 08:36:55 UTC 
Hi pjanik,

thanks for using and supporting OpenOffice.org...

-----------
reassigned to aw

mci->aw: Hi aw, this seems to be something for you...
Comment 4 pavel 2004-08-11 22:39:16 UTC 
fixed by hr:

RCS file: /cvs/framework/binfilter/bf_svx/source/items/svx_svxerr.src,v
revision 1.4
date: 2004/08/10 11:42:21;  author: hr;  state: Exp;  lines: +3 -33
#i10000#: remove double resource
Comment 5 Armin Le Grand 2004-09-09 17:52:48 UTC 
AW; Yes, we found that one at build time. Thanks for the hint. Closing.