Issue 33862 - [cws eforms2] data navigator : crash when add new element into new instance
Summary: [cws eforms2] data navigator : crash when add new element into new instance
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: marc.neumann
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-06 12:28 UTC by marc.neumann
Modified: 2004-11-25 08:52 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description marc.neumann 2004-09-06 12:28:06 UTC 
1. open a new xform
2. open the data navigator
3. add a new instance with the instance button
4. add a new element via the icon to thew new instance
==>> crash
Comment 1 pb 2004-09-09 10:06:26 UTC 
pb -> dvo: please take over. It crashes in the forms dll, but the stack isn't
significant.
Comment 2 openoffice 2004-09-13 18:38:38 UTC 
dvo: Fixed in unoxml/../xpath/xpathapi.?xx

dvo->lo: the fix is in your code; please review in case I didn't do things properly.

The problem is that the xforms extension functions, particularly instance(..),
need to access the XForms model. To do so, the XXPathExtensions object has a
reference to the model, which the instance function implementation then
accesses. There were two bugs:

1) When piping the reference to the function data through the libxml2 C code as
void*, there was one '&' operator too much, so that the code attempted to access
the wrong address. => superflous '&' was removed

2) The actual extension object was not kept alive during XPath evaluation, so
that the void* pointer would point to deleted data. => Now the XXPathAPI object
keeps a list of Reference<XXPathExtension> objects instead of the extension
handles. This way, the extension object remains alive as long a the XXPathAPI
which references it does.
Comment 3 openoffice 2004-10-04 14:23:58 UTC 
assign issue to MSC
Comment 4 openoffice 2004-10-04 14:25:33 UTC 
.
Comment 5 openoffice 2004-10-04 14:27:37 UTC 
reassign to QA
Comment 6 marc.neumann 2004-10-27 11:04:37 UTC 
Hi,

fixed in cws eforms2

Bye Marc
Comment 7 marc.neumann 2004-10-27 11:04:58 UTC 
Hi,

verified in cws eforms2

Bye Marc
Comment 8 marc.neumann 2004-11-25 08:52:09 UTC 
Hi,

fixed in current developer build -> close.
The current developer build can be found at
http://download.openoffice.org/680/index.html
Feel free to reopen if this issue is not fixed in the developer build.

Bye Marc