Issue 33980 - patch to fix major breakage post ab05vba merge to 645
Summary: patch to fix major breakage post ab05vba merge to 645
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1.2
Hardware: PC Linux, all
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-08 18:00 UTC by caolanm
Modified: 2013-08-07 14:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to fix cockup (1.38 KB, patch)
2004-09-08 18:01 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2004-09-08 18:00:36 UTC 
OCX_Control::Import was originally virtual, and remains virtual in the 680
series, but in the ab05vba rework for vba dialog import merged to 645 it was
made non-virtual.

now WW8FormulaControl inherits from this and overrides ::Import. It inherits
from OCX_Control for historical reasons. And really shouldn't do so anymore,
with the change to non-virtual this causes amazing breakage for import check box
fields. 

So the attached patch fixes this major crash problem in 1.1.X, post integration
of the vba stuff. Its good to be applied (and should be) to both 645 and 680
assuming I haven't introduced another brown bag with it.

A sample document to demonstrate is available at
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=132063
Comment 1 caolanm 2004-09-08 18:01:36 UTC 
Created attachment 17603 [details]
patch to fix cockup
Comment 2 caolanm 2004-09-08 18:02:28 UTC 
I think that the right target for this if thats where ab05vba ended up
Comment 3 martin_maher 2004-09-09 10:03:54 UTC 
mmaher: fixed in sw7pp4c (SRX645), I will add this to adarefilterteam (SRC680)
as well.
Comment 4 martin_maher 2004-09-17 12:02:38 UTC 
mmaher: reopen to reassign
Comment 5 martin_maher 2004-09-17 12:03:07 UTC 
mmaher->mru: Fixed in sw7pp4c
Comment 6 michael.ruess 2004-09-21 16:34:28 UTC 
Checked fix in CWS sw7pp4c.
Comment 7 michael.ruess 2004-09-21 16:34:43 UTC 
Verified.
Comment 8 michael.ruess 2004-10-19 12:09:59 UTC 
Checked fix in 645m50.