Issue 34157 - Graphics Styles not modifiable after copying Slide to another Presentation
Summary: Graphics Styles not modifiable after copying Slide to another Presentation
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: formatting (show other issues)
Version: OOo 1.1.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords: needmoreinfo
Depends on:
Blocks:
 
Reported: 2004-09-14 12:27 UTC by christian_heller
Modified: 2005-05-31 14:17 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
OpenOffice Impress presentation (101.88 KB, application/vnd.sun.xml.impress)
2004-09-14 21:20 UTC, christian_heller
no flags Details
OpenOffice Impress presentation (101.71 KB, application/vnd.sun.xml.impress)
2004-09-14 21:21 UTC, christian_heller
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description christian_heller 2004-09-14 12:27:27 UTC
- I have two presentations: one original with black background and another one
with white background for copying slides to be included into white papers

- When I copy a slide from my original presentation to the second presentation,
the copied graphics styles are not modifiable anymore (disabled in context menu
of graphics styles dialog)

- I need this functionality to easily transform former white arrows (from the
presentation with black background) into black arrows (for the second
presentation with white background)

- Why is such not allowed?
I do not see any sense in disabling the "modify" option in the graphics styles
dialog, after copying a slide from one presentation to another.
It would save me many hours/days of work if I could modify copied graphics styles.

Thanks,
Christian
Comment 1 wolframgarten 2004-09-14 12:37:13 UTC
Reassigned to Christian. Please have a look if this is a defect or an
enhancement. Thanks.
Comment 2 christian.guenther 2004-09-14 16:23:16 UTC
Please attach the 2 documents to reprodcue the bug.
Comment 3 christian_heller 2004-09-14 21:20:20 UTC
Created attachment 17715 [details]
OpenOffice Impress presentation
Comment 4 christian_heller 2004-09-14 21:21:40 UTC
Created attachment 17716 [details]
OpenOffice Impress presentation
Comment 5 christian_heller 2004-09-14 21:26:59 UTC
- I added two files, "black.sxi" and "white.sxi" (in relation to their 
background) 
- the "black" is my original, whose slides shall be copied to the "white" 
presentation 
- the "white" presentation initially only contained the slide "client" 
- then I copied the slide "domainmodel" from the "black" presentation to 
the "white" presentation 
- when one now clicks on for example the "object_2" on the slide 
"domainmodel" in the "white" presentation, the graphics style 
"pattern_class_name" is selected in the graphics style dialog 
- when now right-clicking on that graphics style, the context menu only 
offers "new" and "delete" but not the "modify" option 
 
Comment 6 christian_heller 2004-10-18 14:54:35 UTC
- I recognized that after saving, closing and reopening the presentation file,
the newly added styles _are_ modifiable
- perhaps they could be made modifiable without first closing and reopening the file
- so this would be an enhacement
Comment 7 christian.guenther 2005-02-28 13:49:37 UTC
I can't reproduce the bug.
Neither in OOo 1.1.2 nor in the latest Developer Build.
Please tell me if the bug still occures in the latest Developer Build.
Comment 8 christian.guenther 2005-03-09 09:52:41 UTC
Please tell me if you can still reproduce the bug or I must close it as works
for me.
Comment 9 christian_heller 2005-03-10 07:14:09 UTC
Yes, the bug is still there. I describe it once more. 
It's simple to reproduce: 
 
1 I open some existing presentation. 
2 I open a second, new presentation. 
3 I add a simple text box to the new presentation and create a new 
style "test_style" for that text box, e.g. with green background. 
4 I save the new presentation. 
5 I switch both presentations to "Slide View". 
6 I copy the one slide from the new presentation to the existing 
presentation. 
7 I save the existing presentation. 
(not necessarily needed; does not affect the bug) 
8 I switch the existing presentation to "Drawing View". 
9 I open the "Style Editor". 
10 I look for the "test_style" that was copied together with the 
slide from the new presentation to the existing presentation. 
11 Now I right-click on "test_style" to open the context menu. 
12 In the menu, I only see the options "New" and "Delete"; 
the option "Modify" is missing. == BUG?? 
 
13 The bug can be worked around by saving, closing and reopening 
the existing presentation. Afterwards, "Modify" appears normally 
in the context menu. 
 
BTW: I work with Debian Testing and have version 1.1.2 of OpenOffice. 
 
Hope this helps, 
Christian 
 
Comment 10 christian.guenther 2005-03-10 09:01:35 UTC
The step by step description is great.
Now I can reproduce the bug.
Set to new and change the target.
Comment 11 christian.guenther 2005-03-10 09:04:32 UTC
I can reproduce the bug.
Please have a look.
Comment 12 clippka 2005-03-10 10:02:48 UTC
Changed wrong issue type to defect
Comment 13 clippka 2005-03-10 13:14:41 UTC
when the shape is duplicated to the temporary clipboard model,
sdr::AttributeProperties::SetModel() creates a new style. I guess it does not
have the correct flags, will debug this
Comment 14 clippka 2005-03-10 14:19:41 UTC
Ok, actually it was sd::SdStyleSheetPool::CopyGraphicSheets who didn't copy the
stylesheet mask, I fixed that one
Comment 15 clippka 2005-03-14 07:24:11 UTC
verified on cws, back to qa

re-open issue and reassign to cgu@openoffice.org
Comment 16 clippka 2005-03-14 07:24:15 UTC
reassign to cgu@openoffice.org
Comment 17 clippka 2005-03-14 07:24:22 UTC
reset resolution to FIXED
Comment 18 christian.guenther 2005-03-18 18:00:02 UTC
Verified in cws_impress37
Comment 19 christian.guenther 2005-03-18 18:01:21 UTC
Verified
Comment 20 christian.guenther 2005-05-31 14:17:34 UTC
Integrated in src680m106