Issue 37360 - Extended tips always in English
Summary: Extended tips always in English
Status: CLOSED FIXED
Alias: None
Product: documentation
Classification: Unclassified
Component: Online help (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: h.ilter
QA Contact: issues@documentation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-17 18:05 UTC by pavel
Modified: 2004-12-22 15:26 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Fixed xsl stylesheet for compilation (2.46 KB, text/xml)
2004-12-06 14:24 UTC, frank.thomas.peters
no flags Details
*really* fixed version of the embed.xsl stylesheet (2.56 KB, text/xml)
2004-12-08 16:58 UTC, frank.thomas.peters
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-11-17 18:05:33 UTC
Hi,

we have translated one simple extended tip for Bold icon:

#: 05110100.xhp#par_id3153089.2.help.text
msgid ""
"\\<ahelp hid=\\\".uno:Bold\\\" visibility=\\\"visible\\\"\\>Makes the selected
text bold. If the cursor is in a word, the entire word is made bold. If the
selection or word is already bold, the "
"formatting is removed.\\</ahelp\\>"
msgstr "\\<ahelp hid=\\\".uno:Bold\\\" visibility=\\\"visible\\\"\\>Změní
vybraný text na tučný. Pokud je kurzor uvnitř slova, je celé slovo označeno
tučně. Pokud je slovo nebo výběr již tučné, bude toto formátování
odstraněno.\\</ahelp\\>"

The generated GSI file from these POs contains the translation, the translation
is itself merged correctly to localize.sdf file:

source/text/shared/01/localize.sdf:helpcontent2
source\text\shared\01\05110100.xhp 0 help par_id3153089 2 0 cs 14698:\<ahelp
hid=\".uno:Bold\" visibility=\"visible\"\>Změní vybraný text na tučný. Pokud je
kurzor uvnitř slova, je celé slovo označeno tučně. Pokud je slovo nebo výběr již
tučné, bude toto formátování odstraněno.\</ahelp\>    20041113 20:30:42

and this text is also displayed in Czech version' helpcontent - see 

http://tmp.janik.cz/OpenOffice.org/Bold-help.png

You can also see the actual extended tip there.

So this is the description of the problem. Now my findings:

1. I grepped through the complete helpcontent2 directory for '<ahelp
hid=".uno:Bold" visibility="visible">':

These files contains English extended tips:

unxlngi4.pro/misc/cs/text/scalc/main0202.hzip:    <ahelp hid=".uno:Bold"
visibility="visible">Makes the selected text bold. If the cursor is i
unxlngi4.pro/misc/cs/text/scalc/main0205.hzip:    <ahelp hid=".uno:Bold"
visibility="visible">Makes the selected text bold. If the cursor is i
unxlngi4.pro/misc/cs/text/simpress/main0203.hzip: <ahelp hid=".uno:Bold"
visibility="visible">Makes the selected text bold. If the cursor is i
unxlngi4.pro/misc/cs/text/shared/01/05110000.hzip:<ahelp hid=".uno:Bold"
visibility="visible">Makes the selected text bold. If the cursor is i
unxlngi4.pro/misc/cs/text/swriter/main0202.hzip:  <ahelp hid=".uno:Bold"
visibility="visible">Makes the selected text bold. If the cursor is i
unxlngi4.pro/misc/cs/text/swriter/main0220.hzip:  <ahelp hid=".uno:Bold"
visibility="visible">Makes the selected text bold. If the cursor is i

These files contains Czech extended tip:

unxlngi4.pro/misc/cs/text/shared/01/05110100.xhp: <ahelp hid=".uno:Bold"
visibility="visible">Změní vybraný text na tučný. Pokud je kurzo
unxlngi4.pro/misc/cs/text/shared/01/05110100.hzip:<ahelp hid=".uno:Bold"
visibility="visible">Změní vybraný text na tučný. Pokud je kurzo

Something light on here...

I now grepped for files embedding the actual tip:

source/text/scalc/main0202.xhp:  <embed href="text/shared/01/05110100.xhp#fett"/>
source/text/scalc/main0205.xhp:  <embed href="text/shared/01/05110100.xhp#fett"/>
source/text/shared/01/05110000.xhp:<embed href="text/shared/01/05110100.xhp#fett"/>
source/text/simpress/main0203.xhp:<embed href="text/shared/01/05110100.xhp#fett"/>
source/text/swriter/main0202.xhp:<embed href="text/shared/01/05110100.xhp#fett"/>
source/text/swriter/main0220.xhp:  <embed href="text/shared/01/05110100.xhp#fett"/>

These files correspond to the first list. So to sum this up, only the page where
the translation is actually defined is in Czech. The rest (the files that
*embed* the actual translation) are in English, thus non-translated.

And now some questions:

1. Why?

2. From where the tip is actually read? I see that the English tip is inside

pavel@linux:/tmp/SRC680_m62/help/cs> db_dump -p swriter.ht |grep -B1 "Makes the
selected text bold."
 .uno%3ABold
 Makes the selected text bold. If the cursor is in a word, the entire word is
made bold. If the selection or word is already bold, the formatting is removed.

3. Does this affect all languages?
Comment 1 avagula 2004-11-17 18:15:39 UTC
I can confirm appearing of the issue for Estonian in 1.9.62.
Comment 2 pavel 2004-11-22 20:58:03 UTC
set target
Comment 3 pavel 2004-11-28 20:03:30 UTC
This is *basic* functionality that does not work for non-US builds.

Is German build also affected?
Comment 4 andreas.bille 2004-11-29 12:58:14 UTC
Please have a look at it.
Comment 5 ivo.hinkelmann 2004-11-30 16:37:08 UTC
Change the build process and use the right path, back to ABI
Comment 6 andreas.bille 2004-11-30 16:55:56 UTC
The build process is not my part and the path is a parameter on the command
line, which is set by the build process => not my part.
Probably there needs to be some adaption of the makefile's.
Comment 7 frank.thomas.peters 2004-11-30 17:06:29 UTC
> Change the build process and use the right path, back to ABI

What change? What path? Who to change?

>The build process is not my part and the path is a parameter on 
>the command line, which is set by the build process => not my part.
>Probably there needs to be some adaption of the makefile's.

What path? What adaption? Please clarify what needs to be done.
Comment 8 ivo.hinkelmann 2004-12-01 14:44:48 UTC
->fpe: The extended tips in non en-US builds are in English due to the fact that
the "root path" for the xsl tranformation, that includes the embbed tags, points
to the source directory instead of the merged directory. So before the
HelpCompiler extracts the extended tips all files have to be merged ( localized
), because of the "linking dependencies" between the xhp files caused by the
embedded tags. The result is that we need to process the whole helpcontent2
directory twice:

1. localize all files
2. Compile / Extract extended tips

or find a better solution
Comment 9 ivo.hinkelmann 2004-12-01 14:48:55 UTC
->FPE: May be Ause has one or two helping hand
Comment 10 frank.thomas.peters 2004-12-01 15:44:09 UTC
FPE: I am not sure if this can be the root cause. Since extended tips belong to
help ids and these should only be used once they should not appear in embedded
fragments. The question is when is a file localized and when are the extended
tips extracted. I don't own the extended tip extraction nor merging localized files.
Comment 11 ivo.hinkelmann 2004-12-01 16:10:38 UTC
->FPE: Current process is *per directory* first localize, then compile/extract
the extended tips. What we need is first localize each file in *all* directorys,
then compile/extract. 
Comment 12 ivo.hinkelmann 2004-12-01 16:24:41 UTC
If we can remove them, the problem ist imho solved! 
Comment 13 frank.thomas.peters 2004-12-06 14:22:30 UTC
There seem to be two reasons for this bug to occur:
1) bookmarks are embedded in other documents
2) embedded sections may be embedded unlocalized

Here is the proposed solution for 1) (which should fix this bug):
Disregard bookmarks when embedding sections when the help is compiled.

The stylesheet helpcontent2/source/auxiliary/embed.xsl must be replaced. 
I will do the fix in a CWS. I also attach the xsl here so you can run tests and
see if it works correctly.
Comment 14 frank.thomas.peters 2004-12-06 14:24:22 UTC
Created attachment 20166 [details]
Fixed xsl stylesheet for compilation
Comment 15 pavel 2004-12-07 12:49:48 UTC
thanks, I'm going to fix it tonight.
Comment 16 pavel 2004-12-08 09:06:05 UTC
fpe: I put new embed.xsl into helpcontent2 module

oo@oo:~/BuildDir/ooo_SRC680_m65_src/helpcontent2/source/auxiliary> ls -al embed.
xsl 
-rw-r--r--    1 oo       users        2520 Dec  7 22:05 embed.xsl
oo@oo:~/BuildDir/ooo_SRC680_m65_src/helpcontent2/source/auxiliary> 

and did a clean build. But extended tips are still in English. The text is in
Czech in the Help page. I tried this on uno:Bold (Bold button).
Comment 17 frank.thomas.peters 2004-12-08 16:57:20 UTC
FPE: I forgot to make another change. Try the attached embed.xsl. It worked with
German help files. Sorry for the inconvenience-
Comment 18 frank.thomas.peters 2004-12-08 16:58:43 UTC
Created attachment 20271 [details]
*really* fixed version of the embed.xsl stylesheet
Comment 19 frank.thomas.peters 2004-12-08 17:28:20 UTC
FPE: Fixed embed.xsl by adding template for ahelp element in embedded mode
Comment 20 pavel 2004-12-08 23:16:54 UTC
fpe: thanks! really-fixed-embed.xsl solved the problem and I now see extended
tips in the GUI.

Good work!
Comment 21 frank.thomas.peters 2004-12-09 14:59:09 UTC
FPE: 
Hint for QA for verifying:
Take the German version and see if the extended tips are in German.
Comment 22 frank.thomas.peters 2004-12-14 11:52:50 UTC
.
Comment 23 frank.thomas.peters 2004-12-14 11:53:24 UTC
FPE->HI: Please verify in helpaux as discussed
Comment 24 frank.thomas.peters 2004-12-14 11:53:43 UTC
.
Comment 25 h.ilter 2004-12-15 10:09:39 UTC
Extended tips in german version are in german and in english version english => OK
Comment 26 h.ilter 2004-12-22 15:26:41 UTC
Also ok in integrated m67_8854.