Issue 37432 - WW8: NoteRef loses connection to footnote on import
Summary: WW8: NoteRef loses connection to footnote on import
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: 680m62
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2004-11-19 09:00 UTC by michael.ruess
Modified: 2013-08-07 14:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch (8.72 KB, patch)
2004-11-23 12:28 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description michael.ruess 2004-11-19 09:00:42 UTC
with 680m62 open document from issue 37420 -> the references to footnotes have
lost their connection the the referring footnote, thus the field is empty after
import.
In the Edit.Field dialog you can see, that there is not footnote selected to
refer to.
Comment 1 michael.ruess 2004-11-19 09:02:25 UTC
added keword "regression"
Comment 2 caolanm 2004-11-23 12:28:09 UTC
Created attachment 19610 [details]
patch
Comment 3 caolanm 2004-11-23 12:33:02 UTC
cmc->martinm: heres my thinking...

Word misuses its bookmark system to also use bookmarks as variables, so we hold
onto things that get referenced and things that do the referencing to the end of
the document to see if we need to import some of the references of bookmarks as
show variables, which is what the RefToVar is about. The problem is that things
that reference and things that get referenced are put into the same stack, so if
it happens that a referencing thing shows up before the reference then the
IsFtnEdnBkmField says that there is no such bookmark in the document, which is
correct because it hasn't been put in yet.

The attached patch does what I think is the right thing, hold onto both
referencing and referenced until the end of the document, but stick the
referenced things in before the referencing, so IsFtnEdnBkmField reports the
correct information and everything is nice and happy. 
Comment 4 martin_maher 2004-11-23 15:31:39 UTC
mmaher: Added to monaleenfilterteam30
Comment 5 martin_maher 2004-12-01 16:32:43 UTC
mmaher: reopening to reassign
Comment 6 martin_maher 2004-12-01 16:33:43 UTC
mmaher: Reassigning to mru
Comment 7 michael.ruess 2004-12-02 10:12:37 UTC
Verified fix in CWS monaleenfilterteam30.
Comment 8 michael.ruess 2004-12-02 10:14:44 UTC
Verified.
Comment 9 michael.ruess 2005-02-04 16:45:45 UTC
Checked integration in 680m77.