Issue 38446 - --enable-kde and WIDGETSET_KDE_CFLAGS vs KDE_CFLAGS, qt in configure
Summary: --enable-kde and WIDGETSET_KDE_CFLAGS vs KDE_CFLAGS, qt in configure
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: rene
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-05 08:20 UTC by pavel
Modified: 2005-03-31 15:34 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
scp2 patch for KDE VCL plugin (1.10 KB, patch)
2004-12-05 15:04 UTC, pavel
no flags Details | Diff
and add missing dependency (964 bytes, patch)
2004-12-05 20:01 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-12-05 08:20:29 UTC
Hi,

--enable-kde build failure:

--- makefile.mk	08 zář 2004 17:37:19 +0200	1.2
+++ makefile.mk	05 pro 2004 09:17:54 +0100	
@@ -84,7 +84,7 @@
 
 .IF "$(ENABLE_KDE)" != ""
 
-CFLAGS+=$(WIDGETSET_KDE_CFLAGS)
+CFLAGS+=$(KDE_CFLAGS)
 
 SLOFILES=\
 	$(SLO)$/kdedata.obj	\
Comment 1 pavel 2004-12-05 08:36:22 UTC
Even with this patch, the build fails in vcl/util because it can't find KDE libs
and co. This should be applied:

--- makefile.mk	13 lis 2004 18:10:51 +0100	1.63
+++ makefile.mk	05 pro 2004 09:30:06 +0100	
@@ -391,7 +391,7 @@
 SHL5IMPLIB=ikde_plug_
 SHL5LIBS=$(LIB5TARGET)
 # libs for KDE plugin
-SHL5STDLIBS=$(WIDGETSET_KDE_LIBS)
+SHL5STDLIBS=$(KDE_LIBS)
 SHL5STDLIBS+=-l$(SHL2TARGET)
 SHL5STDLIBS+=$(SHL3STDLIBS) -lX11 -ldl
 .ENDIF # "$(ENABLE_KDE)" != ""

and even with this, it can't find stuff.

Environment file contains:

KDE_LIBS="-L/opt/kde3/lib -lkdeui"

but I had to use at least this to be able to link all libs in vcl/util:

KDE_LIBS='-L/opt/kde3/lib -lkdeui -lkdecore -L/usr/lib/qt3/lib/ -lqt-mt'

oo@oo:~/BuildDir-SRC680_m64-1102203527/ooo_SRC680_m64_src/vcl/util> cat
/etc/SuSE-release 
SuSE Linux 9.0 (i586)
VERSION = 9.0

So I have kdebase3-3.1.4-48 and everything from this distro.
Comment 2 pavel 2004-12-05 09:47:03 UTC
This seems to partially duplicate #i37637# and #i36761#. Sorry for that.

kendy: where do you get -lqt-mt in your build?
Comment 3 pavel 2004-12-05 13:03:18 UTC
update Summary accordingly, set target
Comment 4 pavel 2004-12-05 15:03:51 UTC
and finally, I need to patch scp2 to include libvclplug_kde. See attached patch.
Comment 5 pavel 2004-12-05 15:04:24 UTC
Created attachment 20134 [details]
scp2 patch for KDE VCL plugin
Comment 6 pavel 2004-12-05 20:01:31 UTC
Created attachment 20141 [details]
and add missing dependency
Comment 7 kendy 2004-12-06 11:09:29 UTC
kdescp2.diff is a duplicate of 
http://www.openoffice.org/issues/show_bug.cgi?id=35433, fixed in vcl32. 
 
The missing dependecy should have been fixed, see 
http://www.openoffice.org/issues/show_bug.cgi?id=38446, but was not, it seems. 
It builds fine for me, so I did not notice, sorry :( Do you have a CWS to 
commit vclbuild.diff, please? vcl32 seems to be ready for QA already. 
 
Sorry for the missing -lqt-mt; it just works for me automagically, but you are 
right that it should be listed in KDE_LIBS. 
Comment 8 kendy 2004-12-06 11:13:16 UTC
Not #i38446#, but http://www.openoffice.org/issues/show_bug.cgi?id=35430 in the 
previous comment; cut'n'paste from wrong window:( 
Comment 9 pavel 2004-12-08 19:09:11 UTC
I fixed vcl/prj/build.lst in pj14.
Comment 10 pavel 2004-12-08 19:20:11 UTC
kendy: now it looks like the following should be done:
configure.in should be extended: by adding -lkdecore -lqt-mt to KDE_LIBS and by
adding -L$QTLIB (which is to be found out) to KDE_LIBS.

rodarvus: can you help here, please?


Comment 11 rene 2005-01-14 11:13:22 UTC
pavel: Will look over it and do it in configure4 
 
Comment 12 pavel 2005-01-15 11:51:08 UTC
OK, reassigning to rene.
Comment 13 rene 2005-01-17 14:11:37 UTC
committed to cws_src680_configure4. Please check. 
Comment 14 rene 2005-01-20 18:25:12 UTC
set to FIXED 
Comment 15 quetschke 2005-01-24 00:16:23 UTC
Seen in configure4
Comment 16 rene 2005-03-31 15:34:17 UTC
close