Issue 41140 - Patches to ICU for Khmer support
Summary: Patches to ICU for Khmer support
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ooo
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-23 03:45 UTC by lists
Modified: 2013-08-07 15:00 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch for inclusion of support for Khmer script in the OOo version of ICU 2.6 (11.29 KB, application/x-compressed)
2005-01-23 03:48 UTC, lists
no flags Details
the patch that compiles now correctly (11.96 KB, application/octet-stream)
2005-02-08 11:56 UTC, jenskhmeros
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description lists 2005-01-23 03:45:50 UTC
The attached files contain a module for the support of Khmer language in ICU.
The module has been fully tested and included in the current ICU source (after
release of ICU 3.2).

The module has 4 new files and that need to be placed in the icu/source/layout
directory, and a small modification to file LayoutEngine.cpp for the module to
be called (and the include file included).

I am attaching a diff over the ICU 2.6 source for this file, after modifying the
source with the official patch in extern/icu/icu-2.6.patch.

I followed this process:

1) I downloaded the source in extern/icu/download/icu-2.6.tar.gz
2) I modified it with the patch in extern/icu/icu-2.6.patch.
3) I made sure that the logic in 2.6 is exactly the same as in 3.2 (I had asked
the ICU layout engine maintainer and said that it should probably work the same).
4) I applied to the 2.6 icu/source/layout/LayoutEngine.cpp file the patch that I
had developed for ICU 3.2, it fits perfectly.
5) I diff -u the LayoutEngine.cpp file obtained in point 2) above with the one
modified by my patch for 3.2, and I obtain the LayoutEngine.cpp.diff included in
the zip file attached. 

The patch is prepared to be installed from inside the /icu/ directory (in which
the source directory is), the files to be installed are also correctly place in
the zip file in reference to that directory (so inside the zip file they are in
/source/layout/).

I know that this is not enough to make the inclusion, Eike posted sometime ago
the following, in reference to patching the ICU 2.6 copy used in OOo:

"Just to mention that this patch file MUST NOT be created manually. There
is a dmake target that does this from the sources available under
${INPATH}/misc/build/icu/ after the module was built once, and files
were modified: dmake create_patch

However, you have to create the patch on a Unix or Linux platform, using
Windows will spoil things."

I am submitting this as a normal patch because this is how far my technical
knowledge goes, but I hope that it will facilitate the process.

I have assigned this to ihi supposing that this falls into l10n issues, if not,
please reassign.
Comment 1 lists 2005-01-23 03:48:04 UTC
Created attachment 21771 [details]
Patch for inclusion of support for Khmer script in the OOo version of ICU 2.6
Comment 2 lists 2005-01-23 10:10:13 UTC
Well... it was not so easy. ICU 3.2 IS different from 2.6. New data types are
defined, so the source really needs to be adapted to 2.6.

The above patch should be ignored. We are working on the real one.
Comment 3 ivo.hinkelmann 2005-01-24 12:37:40 UTC
-> Eike , something for you
Comment 4 jenskhmeros 2005-02-08 11:56:16 UTC
Created attachment 22329 [details]
the patch that compiles now correctly
Comment 5 ooo 2005-02-08 13:09:37 UTC
Javier,
A patch created of an already patched (by means of our build environment)
external source is absolutely perfect. The other patch created by dmake I
mentioned is necessary for the final patch file that is checked in to CVS.

Jens,
Thanks for relieving the burdon from me to adapt this to ICU 2.6 :-)  Otherwise
I would probably have rejected the patch.

I added this issue to CWS localedata3.

Eike
Comment 6 ooo 2005-02-09 15:33:19 UTC
On branch cws_src680_localedata3:
icu/icu-2.6.patch 1.7.6.1
icu/makefile.mk 1.21.6.1

Note that I also added the additional files to Makefile.in, layout.dsp,
layout.vcproj and layoutobj.inc to have them built properly, see icu-2.6.patch
Comment 7 ooo 2005-03-11 20:07:26 UTC
Verified presence in CWS build.

Note that additionally to the files mentioned above icu/makefiles.zip 1.4.16.1
was added to make the whole thing build under Windows. Sick.
Comment 8 ooo 2005-03-31 16:54:23 UTC
Present in master, closing.