Apache OpenOffice (AOO) Bugzilla – Issue 41140
Patches to ICU for Khmer support
Last modified: 2013-08-07 15:00:08 UTC
The attached files contain a module for the support of Khmer language in ICU. The module has been fully tested and included in the current ICU source (after release of ICU 3.2). The module has 4 new files and that need to be placed in the icu/source/layout directory, and a small modification to file LayoutEngine.cpp for the module to be called (and the include file included). I am attaching a diff over the ICU 2.6 source for this file, after modifying the source with the official patch in extern/icu/icu-2.6.patch. I followed this process: 1) I downloaded the source in extern/icu/download/icu-2.6.tar.gz 2) I modified it with the patch in extern/icu/icu-2.6.patch. 3) I made sure that the logic in 2.6 is exactly the same as in 3.2 (I had asked the ICU layout engine maintainer and said that it should probably work the same). 4) I applied to the 2.6 icu/source/layout/LayoutEngine.cpp file the patch that I had developed for ICU 3.2, it fits perfectly. 5) I diff -u the LayoutEngine.cpp file obtained in point 2) above with the one modified by my patch for 3.2, and I obtain the LayoutEngine.cpp.diff included in the zip file attached. The patch is prepared to be installed from inside the /icu/ directory (in which the source directory is), the files to be installed are also correctly place in the zip file in reference to that directory (so inside the zip file they are in /source/layout/). I know that this is not enough to make the inclusion, Eike posted sometime ago the following, in reference to patching the ICU 2.6 copy used in OOo: "Just to mention that this patch file MUST NOT be created manually. There is a dmake target that does this from the sources available under ${INPATH}/misc/build/icu/ after the module was built once, and files were modified: dmake create_patch However, you have to create the patch on a Unix or Linux platform, using Windows will spoil things." I am submitting this as a normal patch because this is how far my technical knowledge goes, but I hope that it will facilitate the process. I have assigned this to ihi supposing that this falls into l10n issues, if not, please reassign.
Created attachment 21771 [details] Patch for inclusion of support for Khmer script in the OOo version of ICU 2.6
Well... it was not so easy. ICU 3.2 IS different from 2.6. New data types are defined, so the source really needs to be adapted to 2.6. The above patch should be ignored. We are working on the real one.
-> Eike , something for you
Created attachment 22329 [details] the patch that compiles now correctly
Javier, A patch created of an already patched (by means of our build environment) external source is absolutely perfect. The other patch created by dmake I mentioned is necessary for the final patch file that is checked in to CVS. Jens, Thanks for relieving the burdon from me to adapt this to ICU 2.6 :-) Otherwise I would probably have rejected the patch. I added this issue to CWS localedata3. Eike
On branch cws_src680_localedata3: icu/icu-2.6.patch 1.7.6.1 icu/makefile.mk 1.21.6.1 Note that I also added the additional files to Makefile.in, layout.dsp, layout.vcproj and layoutobj.inc to have them built properly, see icu-2.6.patch
Verified presence in CWS build. Note that additionally to the files mentioned above icu/makefiles.zip 1.4.16.1 was added to make the whole thing build under Windows. Sick.
Present in master, closing.