Issue 41148 - export/xhtml/header.xsl: OpenOffice vs. OpenOffice.org
Summary: export/xhtml/header.xsl: OpenOffice vs. OpenOffice.org
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: OOo 2.0
Assignee: pavel
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-23 10:03 UTC by pavel
Modified: 2006-05-23 07:26 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-01-23 10:03:47 UTC
Hi,

ooo_SRC680_m73_src/filter/source/xslt/export/xhtml/header.xsl:            
<xsl:attribute name="content">StarOffice/OpenOffice XSLT
(http://xml.openoffice.org/sx2ml)</xsl:attribute>

Our project is named OpenOffice.org, Please change the content to match the name
properly.
Comment 1 pavel 2005-01-23 10:04:09 UTC
set target.
Comment 2 pavel 2005-01-29 15:06:04 UTC
tm: is it OK to commit this change?

-            <xsl:attribute name="content">StarOffice/OpenOffice XSLT
(http://xml.openoffice.org/sx2ml)</xsl:attribute>
+            <xsl:attribute name="content">StarOffice/OpenOffice.org XSLT
(http://xml.openoffice.org/sx2ml)</xsl:attribute>

Comment 3 thorsten.martens 2005-01-31 11:24:20 UTC
TM->MH: Please have a look, thanks !
Comment 4 Martin Hollmichel 2005-01-31 12:11:01 UTC
is therey any spec available ?
Comment 5 svante.schubert 2005-01-31 12:27:06 UTC
Reassigned as discussed by phone
Comment 6 falko.tesch 2005-02-02 11:59:00 UTC
FT: This issue needs further clarification on naming.
Comment 7 falko.tesch 2005-03-07 07:02:28 UTC
FT: It is not OK to submit this patch, since "StarOffice" is hard-coded here. We
should change the code to a place-holder. E.g.: 
<xsl:attribute name="content">%PRODUCTVERSION XSLT
Comment 8 svante.schubert 2005-03-07 12:25:55 UTC
Please offer more details about the placeholder-exhanging mechanism.
Comment 9 falko.tesch 2005-03-07 12:54:16 UTC
FT: 
Comment 10 falko.tesch 2005-03-29 13:01:27 UTC
FT: Targeted
Comment 11 falko.tesch 2005-03-29 13:01:57 UTC
.
Comment 12 pavel 2005-04-06 15:51:16 UTC
The issue is now targeted to 2.0.2. Why? Can't we simply remove the names?

What if I change it to say only OpenOffice.org? As this is not critical for
OpenOffice.org, it is not critical for StarOffice/StarSuite. Is it OK with you?
If not, why?
Comment 13 falko.tesch 2005-04-18 13:34:08 UTC
FT: This issue is not critical for 2.0.x functionality. Also 2.0 has closed its
gates for fixes that affect the UI anyway.
Give the sheer amount of open (and more important) issues that are already
re-targeted to 2.0.1 I will leave this one on 2.0.2.
Comment 14 falko.tesch 2005-07-08 10:10:11 UTC
MH: If patch is OK please submit. The initial naming problem is "no more". Thx.
Comment 15 pavel 2005-07-28 07:43:50 UTC
I'll change OpenOffice -> OpenOffice.org for 2.0.

If there are other problems (like StarOffice/StarSuite, ...), please file new issue.
Comment 16 pavel 2005-07-28 07:44:08 UTC
started.
Comment 17 pavel 2005-07-29 11:25:52 UTC
Fixed OpenOffice -> OpenOffice.org in pj32.
Comment 18 pavel 2005-08-04 06:08:23 UTC
Verified in my local build.
Comment 19 pavel 2006-05-23 07:26:57 UTC
Closing.