Apache OpenOffice (AOO) Bugzilla – Issue 41688
Quattro Pro 6.0 import filter
Last modified: 2013-08-07 15:13:18 UTC
Check-in Shilpas Quattro Pro 6.0 import filter. Suitable test (.wb2) files can be found here: http://go-oo.org/ooo-build/test/qpro/ Specification posted to the specs list etc.
Committed; Eike could you have a read of the changes ? we also need a suitable QA person to assign it to in EIS when you're happy. I've committed this to the new CWS: 'qpro02' since I managed to screw up qpro01.
Michael, You mentioned > Specification posted to the specs list etc. but there is no specification available. Specs also don't go to any list, but instead an "iTeam" is formed (at least a developer, one member of user experience, a QA representative, and a member of the documentation team) who have to agree on a spec, and the spec is to be checked in to the CVS of specs.openoffice.org, in this case specs/www/calc/... Eike
Created attachment 26191 [details] A sample quattro pro file that tests formulas.
*** Issue 48585 has been marked as a duplicate of this issue. ***
Created attachment 27037 [details] Specification for QPro 6.0 filter work
I just checked the spec using our new tool http://eis.services.openoffice.org/EIS2/guide.CheckSpecification?url=http%3A%2F%2Fwww.openoffice.org%2Fnonav%2Fissues%2Fshowattachment.cgi%2F27037%2Fqprospec.sxw and all was fine. Thanks Eike
Created attachment 27128 [details] much more comprehensive formula test - cf. all sheets ...
Eike - over to you - who are we blocking on here ?
Aligning target to CWS qpro03.
Hi Shilpa, Sigh.. I already thought we were through with this and wanted to set the CWS to ready-for-QA, but I just tried the formulat.wb2 attachment in a non-product version of the CWS I resynced to m126 yesterday. It throws a zillion debug-output assertions about undefined TokenPool states. Please fix that. Btw, you seem to have two OOo accounts, sshilpa and shilpas, which one to use? Thanks Eike
I will look at the issue that u have mentioned. My account that i use is shilpas.
Created attachment 30167 [details] Testdocument for various font types
Created attachment 30168 [details] sample test document
Hi Shilpa, Please use appropriate mime types, *.wb2 are not of type application/vnd.sun.xml.calc. If nothing fits or there is no proper mime type for the file format, use application/octet-stream for binary files. In the current implementation present in CWS qpro03, the FON.WB2 looks almost good. Almost, because cells C7:C12 are not bold as they claim to be, and G4 is bold italic instead of bold underlined, G11 and G12 are bold italic underlined and not bold underlined like the rest of the column, though the content says bold italic instead, which may be a copy&paste error. In complex.wb2, almost all cells are italic underlined, except a few where it seems other attributes are set. The font sizes are not imported, should they? The spec doesn't mention it. After having again applied the latest patch you sent by mail, the results of FON.WB2 did not change, but complex.wb2 now displays all cells that previously were italic underlined as bold italic underlined. This seems to be an error. I assume that those cells should not have a font attribution at all instead. Please consider the unitialized array memory of ScQProStyle I mentioned in my reply mail together with how the font style indices are used for a possible cause of the error. Please submit a working fix (cvs diff -u -r cws_src680_qpro03) until Monday next week, otherwise we may have to postpone the CWS to OOo2.0.2 Thanks Eike
So - this is *embarassingly* bad; sorry for the unnecessary pain Eike. * Your comments on formatting are all correct - þe FON.WB2 is badly constructed & inaccurate. The good news is though that it renders the same with OO.o & Win32. I attach a fixed font2.wb2 file that should do better (at least for the bits you pointed out). * Shilpa didn't understand about initializing members; I've fixed that. * I added the font height import in passing too. Sorry for the pain.
Created attachment 30440 [details] fixes
Created attachment 30441 [details] fixed font file
spec-link added
Filter is not registered in MIME, and task is in wrong status (not fixed)
As already clarified internally, this is a misunderstanding. It is not necessary to have a distinct MIME type assigned. Furthermore, there is no MIME type registered with IANA, see http://www.iana.org/assignments/media-types/application/, only some types used in the wild, for examples see http://filext.com/detaillist.php?extdetail=WB2
Reassigning to QA again. re-open issue and reassign to oc@openoffice.org
reassign to oc@openoffice.org
reset resolution to FIXED
Created attachment 33521 [details] QPro6 format Testdoc
Sorry to tell you but this Issue isn't fixed from my point of view.
fst: interesting - when I load your test sheet I get a dialog saying: Title: Quattro Pro Text: ! "Unknown records encountered. This file may be created by the new release of QPW.: Z:\AOUPEC~0.WB2 {FileOpen}" Are you sure you're only using the formulae & functions available in QPro 6.0 ? ;-> re-marking FIXED => back to QA.
So - checkout: http://go-oo.org/~michael/qpro.png http://go-oo.org/~michael/oopro.png Ultimately - I'm not too interested in completeness here - what is there is useful & usable. Lets cut the spec. down to list only the functions that work & calculate the expected result here - and leave the rest as an added bonus.
verified on cws qpro03
changed target
changed Issue type to FEATURE on request
closed because feature available in OOo2.02m156