Issue 41791 - testshl2 has some issues with stl code
Summary: testshl2 has some issues with stl code
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P4 Trivial
Target Milestone: ---
Assignee: lars.langhans
QA Contact: issues@api
URL:
Keywords: oooqa
: 41790 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-02-01 11:38 UTC by lars.langhans
Modified: 2013-02-24 21:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lars.langhans 2005-02-01 11:38:00 UTC 
a vector iterator isn't a pointer in every STL version and in empty vector's not
NULL every time.

This is the fix.

diff -r1.4 getopt.cxx
556c556
<       if ( nameVec.end() ) {
---

>>       if ( !nameVec.empty() ) {

560c560
<       if ( paramVec.end() ) {
---

>>       if ( !paramVec.empty() ) {

860c860
<               if (m_opthash[opt].begin())
---

>>               if (!m_opthash[opt].empty())
Comment 1 lars.langhans 2005-02-01 11:45:55 UTC 
fixed
Comment 2 lars.langhans 2005-02-25 11:19:09 UTC 
*** Issue 41790 has been marked as a duplicate of this issue. ***
Comment 3 ace_dent 2008-05-17 21:22:32 UTC 
The Issue you raised has been marked as 'Resolved' and not updated within the
last 1 year+. I am therefore setting this issue to 'Verified' as the first step
towards Closing it. If you feel this is incorrect, please re-open the issue and
add any comments.

Many thanks,
Andrew
 
Cleaning-up and Closing old Issues
~ The Grand Bug Squash, pre v3 ~
http://marketing.openoffice.org/3.0/announcementbeta.html
Comment 4 ace_dent 2008-05-17 23:25:40 UTC 
As per previous posting: Verified -> Closed.
A Closed Issue is a Happy Issue (TM).

Regards,
Andrew