Issue 42445 - Slide sorter bar: Crash when I click beside a slide and press page down
Summary: Slide sorter bar: Crash when I click beside a slide and press page down
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: ui (show other issues)
Version: 680m77
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-10 17:02 UTC by christian.guenther
Modified: 2005-04-08 10:13 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description christian.guenther 2005-02-10 17:02:01 UTC 
- start an impress / Draw
- insert some slides
- scroll in the slide sorter bar to the bottom of the slides
- click beside a slide
- you jump back to the first slide
- press now the page down button
-> crash
Comment 1 groucho266 2005-02-10 17:32:54 UTC 
Here we have two separate problems:
1) The scrolling back to the first slide is a bug in the code that scrolls a
modified selection into the visible area.  The empty selection is handled wrong.

2) Pressing the PageDown key crashes the office because it tries to go down one
page from the current page.  There is no current page because the selection is
empty.  Referencing the NULL pointer returned by GetActualPage() leads to the crash.
Comment 2 groucho266 2005-02-11 12:24:40 UTC 
Fixed 1) by ignoring the empty selection in
SlideSorterController::MakeSelectionVisible() and 2) by having
SlideSorterController::GetActualPage() return the current page of the view shell
in the center pane (when possible) and by guarding
SelectionFunction::GotoNextPage() against an empty pointer to the current page.
Comment 3 clippka 2005-02-14 13:50:29 UTC 
reopened to send back to qa
Comment 4 clippka 2005-02-14 13:51:06 UTC 
send back to qa
Comment 5 clippka 2005-02-14 13:54:27 UTC 
set back to fixed
Comment 6 christian.guenther 2005-02-21 14:15:11 UTC 
Verified in cws impress34
Comment 7 wolframgarten 2005-04-08 10:13:27 UTC 
Tested in master m91. Closed.