Issue 43451 - Crash when I change a wrong word in the spellchecker
Summary: Crash when I change a wrong word in the spellchecker
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m80
Hardware: All Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords:
: 44687 45916 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-02-24 11:02 UTC by christian.guenther
Modified: 2005-04-08 10:28 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
crashreporter stack (10.32 KB, text/xml)
2005-02-24 14:14 UTC, clippka
no flags Details
Stack trace obtained when it crashed on Suse 9.3 beta (5.26 KB, text/plain)
2005-02-25 06:55 UTC, nagashree
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description christian.guenther 2005-02-24 11:02:08 UTC
this issue seems to be Linux only
- start an impress with an title text layout
- writea wrong word
- press F7 to start the spellchecker
- click on 'Change'
-> you get a crash.
Comment 1 clippka 2005-02-24 14:10:28 UTC
bm, I also can't reproduce this issue. CGU can reproduce it on his jds in m78
and m80. I suspekt its a jds only problem. Maybe the GTK on the stack is a hint?
Comment 2 clippka 2005-02-24 14:14:56 UTC
Created attachment 22990 [details]
crashreporter stack
Comment 3 nagashree 2005-02-25 06:55:08 UTC
Created attachment 23018 [details]
Stack trace obtained when it crashed on Suse 9.3 beta
Comment 4 bjoern.milcke 2005-02-28 15:38:06 UTC
Now, I also got a stack (starting with a niceness of -11 helped):

#0  0xb67bff6f in OutlinerView::GetSelection (this=0x0) at
/work/dev/impress36/SRC680/svx/source/outliner/outlvw.cxx:1416
#1  0xad655855 in sd::Outliner::GetNextSpellSentence (this=0xaba21710) at
/work/dev/impress36/SRC680/sd/source/ui/view/Outliner.cxx:504
#2  0xad70e703 in sd::SpellDialogChildWindow::GetNextWrongSentence
(this=0xac640be8) at
/work/dev/impress36/SRC680/sd/source/ui/dlg/SpellDialogChildWindow.cxx:141
#3  0xab98990f in svx::SpellDialog::GetNextSentence_Impl (this=0xaba42f28,
bUseSavedSentence=false) at _uninitialized.h:63
#4  0xab989c57 in svx::SpellDialog::SpellContinue_Impl (this=0xaba42f28,
bUseSavedSentence=false) at SpellDialog.hxx:180
#5  0xab98a970 in svx::SpellDialog::ChangeHdl (this=0xaba42f28) at
/net/jumbo.germany/sol1/SRC680/src/svx/source/dialog/SpellDialog.cxx:563
[...]

As you can see the view returned by GetView(0) of the outliner is NULL. Well, I
suspected this, but now I have a starting point for debugging ...
Comment 5 bjoern.milcke 2005-02-28 17:47:32 UTC
->AF: I haven't found out much more. When setting breakpoints in
Outliner::InsertView() and RemoveView() I never get the crash. It would be
interesting which code calls the last RemoveView(0) just before the crash. I
have added some code to my svx/.../outliner.cxx that prints the parameters and a
stack trace for these functions. If you like I can give you the patched
libraries, or I try to get an output for a crash and attach it to this issue.
(Maybe you have an idea what happens with the help of the above backtrace.)
Comment 6 groucho266 2005-03-02 11:13:54 UTC
Accepted.
Comment 7 groucho266 2005-03-03 17:18:32 UTC
I applied the simple fix: In GetNextSpellSentence() the OutlinerView is checked
for being NULL.  When so then it is not accessed.

Why the view is NULL in the first place I do not yet know.
Comment 8 groucho266 2005-03-14 13:34:22 UTC
Back to QA for verification.

re-open issue and reassign to cgu@openoffice.org
Comment 9 groucho266 2005-03-14 13:34:26 UTC
reassign to cgu@openoffice.org
Comment 10 groucho266 2005-03-14 13:34:29 UTC
reset resolution to FIXED
Comment 11 wolframgarten 2005-03-15 14:52:21 UTC
*** Issue 44687 has been marked as a duplicate of this issue. ***
Comment 12 christian.guenther 2005-03-16 18:46:57 UTC
Now I don't get a crash but the corrected word would not be replaced.
also linux only
Comment 13 christian.guenther 2005-03-16 18:47:25 UTC
Back to af
Comment 14 groucho266 2005-03-17 15:16:40 UTC
I am setting the resolution again to FIXED because a) the crash does not occur
anymore and b) the problem with the text not being substituted is duplicate to
(or at least has the same root cause as) issue 44399.
Comment 15 groucho266 2005-03-17 15:17:23 UTC
Back to QA.

re-open issue and reassign to cgu@openoffice.org
Comment 16 groucho266 2005-03-17 15:17:30 UTC
reassign to cgu@openoffice.org
Comment 17 groucho266 2005-03-17 15:17:34 UTC
reset resolution to FIXED
Comment 18 christian.guenther 2005-03-17 16:09:43 UTC
Verified in cws impress37
Comment 19 groucho266 2005-03-24 12:38:59 UTC
*** Issue 45916 has been marked as a duplicate of this issue. ***
Comment 20 wolframgarten 2005-04-08 10:28:18 UTC
Tested in master m91. CLosed.