Issue 47919 - Catch_signals(fn) problems
Summary: Catch_signals(fn) problems
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-22 05:33 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Example patch for dmake (3.36 KB, patch)
2005-04-22 05:48 UTC, quetschke
no flags Details | Diff
Patch for dmake/ (38.42 KB, patch)
2006-02-02 04:34 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2005-04-22 05:33:41 UTC
Catch_signals(fn) in sysintf calls signal() with a function (Quit) without
a parameter, but required is Quit(int)
Comment 1 quetschke 2005-04-22 05:48:32 UTC
Created attachment 25328 [details]
Example patch for dmake
Comment 2 quetschke 2005-04-22 06:12:59 UTC
The previous patch is MSVC only and has to be adapted for the other OSs but
shows what has to be done.
Comment 3 quetschke 2006-02-02 04:34:24 UTC
Created attachment 33777 [details]
Patch for dmake/
Comment 4 quetschke 2006-02-02 04:42:48 UTC
Committed to dmake43p01.

@ause: Please verify!
Comment 5 quetschke 2006-02-02 04:49:40 UTC
Oops, typo:

+++ dmake/dmake.c       2 Feb 2006 04:48:34 -0000
@@ -713,7 +713,7 @@
 
       vfprintf( stderr, fmt, args );
       putc( '\n', stderr );
-      if( errflg && !Continue ) Quit(0) );
+      if( errflg && !Continue ) Quit(0);
    }
 }
 
Fixed!
Comment 6 shay 2006-02-02 16:01:39 UTC
@vq: Thanks for the fix!  I applied the patch manually and it builds fine for me
without the warnings that I had previously.
However, I notice that you say you've committed the patch to dmake43p01.  It
wasn't in the sources that I checked out, so I've obviously pulled the wrong
sources down.
I used the cws_src680_dmake43p01 branch when I got the sources, which is what I
was using last year when when I last did a build of dmake.
What is the current branch that I should be using, and moreover, how can I find
out for myself what the current branch is so that I don't have to keep asking in
the future?
Comment 7 quetschke 2006-02-02 17:17:18 UTC
Hi Steve!

Yes, I committed to cws_src680_dmake43p01. It is still the current branch as it
didn't get integrated yet into HEAD. Maybe anoncvs was not yet synchronized
with the "developers" cvs. It's running on a different server to lessen the load.

Please try again and if it is still missing complain loudly ;)

You can also check <http://tools.openoffice.org/source/browse/tools/dmake/>.
This link should be always up to date.

BTW, can you please check that I didn't break anything for your setup. See
ChangeLog and NEWS file, I fixed a few more things and hope that everything
still works outside of OpenOffice.org.

I'll try to keep <http://tools.openoffice.org/dmake/> up to date if the current
branch changes. But feel free to ask.
Comment 8 shay 2006-02-02 17:56:39 UTC
OK, I got it from anoncvs now, so it must have just been lagging behind a bit.

It still builds cleanly for me and seems to work OK building perl (I'll give it
more of a thrashing later), but it seems to have one slight hiccup when
(re)building itself.

Steps to reproduce are as follows:

1. Run "make win95-vpp40".  This works fine (using VC++ 6.0 on WinXP).
2. Copy dmake.exe and startup/ from source tree to C:\dmake
3. Delete dmake.exe and objects/ from source tree
4. Run "C:\dmake\dmake.exe".

The last step recompiles all the object files and relinks the executable, but
then throws out this error:

dmake.exe:  Error: -- `..\..\..startup/template.mk' not found, and can't be made

I'm not sure why yet, as I haven't had time to look into it.

In my previous build of dmake (using sources taken from the same CVS branch on
06 Jun 2005) dmake.exe was able to (re)build itself without this error.

I also tried using that old dmake build to build the new dmake sources that I've
just checked out and that works fine without the error, so it does look like a
problem with the new dmake.exe.

Should I log this under a new issue number?
Comment 9 hjs 2006-04-19 18:13:31 UTC
.
Comment 10 hjs 2006-04-21 17:31:18 UTC
.