Issue 48608 - formula-Toolbar doesn't use high-contrast icons (although these are present)
Summary: formula-Toolbar doesn't use high-contrast icons (although these are present)
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: 680m98
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords: accessibility, oooqa
Depends on:
Blocks:
 
Reported: 2005-05-03 12:07 UTC by lohmaier
Modified: 2013-08-07 14:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
screenshot showing writer's formula bar (& calc) in high-contrast-mode (29.65 KB, image/png)
2005-05-03 12:08 UTC, lohmaier 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lohmaier 2005-05-03 12:07:03 UTC 
To reproduce (running gnome):

0) Set your theme to High-contrast (black)
1) Start OOo writer 
2) Press <F2> to display the formula-toolbar
   -> the formula-icon & the other ones still are the regular ones
3) Start OOo calc
   -> this toolbar uses the correct high-contrast version of the icon.

Further details:
the icons are:

default_images/sw/imglst/sc20556.png (formula-icon)
default_images/sw/imglst/sc20557.png (the "X")
default_images/sw/imglst/sc20558.png (the "check")

the relevant high-contrast versions are:
default_images/sw/imglst/sch20556.png (formula-icon)
default_images/sw/imglst/sch20557.png (the "X")
default_images/sw/imglst/sch20558.png (the "check")

Both versions are included in images.zip, but as you can see from the screenshot
only the regular ones get applied.
The same is true for the large icons (lc*).

Calc uses the same formula-icon, but calc's version is stored elsewhere:
default_images/res/commandimagelist/sc_insertformula.png

Thus writer issue.
related: issue 48171
Comment 1 lohmaier 2005-05-03 12:08:47 UTC 
Created attachment 25746 [details]
screenshot showing writer's formula bar (& calc) in high-contrast-mode
Comment 2 lohmaier 2005-05-03 12:10:17 UTC 
accessibility keyword.
Comment 3 michael.ruess 2005-05-03 12:17:32 UTC 
Reassigned to ES.
Comment 4 eric.savary 2005-05-26 22:10:15 UTC 
ES->STS: as described.
Comment 5 mdxonefour 2005-09-29 10:56:41 UTC 
re-targeted to OOo 3.0
Comment 6 stella.schulze 2005-10-26 10:34:12 UTC 
STS -> TL:  Hi Thomas, all these high contrast icons are right. Please make them
available in the Office UI.
Comment 7 thomas.lange 2005-10-26 11:23:08 UTC 
.
Comment 8 thomas.lange 2006-06-20 14:24:45 UTC 
.
Comment 9 Mathias_Bauer 2006-07-10 10:52:46 UTC 
changing target
Comment 10 thomas.lange 2006-07-11 12:32:02 UTC 
Fixed in CWS a11y204.

Files changed:
- sw/source/ui/inc/inputwin.hxx
- sw/source/ui/ribbar/inputwin.cxx
Comment 11 thomas.lange 2006-07-27 11:07:50 UTC 
.
Comment 12 eric.savary 2006-07-31 14:55:58 UTC 
Fixed but failed.
Comment 13 eric.savary 2006-07-31 14:56:47 UTC 
Reassigned
Comment 14 thomas.lange 2006-08-01 14:15:29 UTC 
Evaluation of bDark fixed:
        //BOOL bDark = GetDisplayBackground().GetColor().IsDark();
	BOOL bDark = GetBackground().GetColor().IsDark();

The 'correct' source code I was told to copy from Calc also had this problem.
Though no one had found it there yet.

I told DR about this and he is going to fix it in Calc separatley.
Comment 15 thomas.lange 2006-08-01 15:23:55 UTC 
.
Comment 16 eric.savary 2006-08-01 16:45:15 UTC 
mh...sorry, but still "fixed but failed".
Comment 17 eric.savary 2006-08-01 16:46:10 UTC 
Reassigned
Comment 18 thomas.lange 2006-08-02 10:57:45 UTC 
Yet another fix for the evaluation of bDark in hi-contrast mode.
Comment 19 thomas.lange 2006-08-02 11:01:51 UTC 
TL->ES: CD said this should be checked with Windows, Gnome and KDE.
Comment 20 thomas.lange 2006-08-02 13:30:42 UTC 
.
Comment 21 eric.savary 2006-08-02 15:42:05 UTC 
VERIFIED
Comment 22 eric.savary 2006-08-15 15:24:42 UTC 
Ok in m181