Issue 48649 - packimages.pl doesn't trigger rebuild on new *.ilst files
Summary: packimages.pl doesn't trigger rebuild on new *.ilst files
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: 680m98
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-03 17:31 UTC by hjs
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2005-05-03 17:31:47 UTC
the packing script just matches the modification dates even if a new *.ilst file
was added.
Comment 1 flibby05 2005-05-22 18:48:25 UTC
sub is_file_newer, lines 318..

    foreach ( sort keys %{$test_hash_ref} ) {
        my $path = $test_hash_ref->{$_};
        $path .= "/" if "$path" ne "";
        $path .= "$_";
        print_message("checking '$path' ...") if $extra_verbose;
        my $mtime = (stat($path))[9];
        return 1 if $reference_stamp < $mtime;
    }


I think correcting the following minor typo should solve it:

$path .= "$_";
->
$path .= $_;
Comment 2 hjs 2005-06-08 18:12:00 UTC
i don't think so. the line mentioned is no typo but the atempt to quote whatever
filename may be in "$_".

the actual issue is that the filedates are checked but not if a specific file
was already taken into account at last run. imaginge a incomplete "d.lst" which
fails to deliver a specific "*.res" file (and the according "*.ilst"). if this
"d.lst" is fixed some day but the "*.res" is not recreated, the now delivered
"*.ilst" file will not trigger packing the images. the "*.ilst" is older than
the "images.zip".

one possible fix could be to protocol the "*.ilst" file used to create the
archive last time. if there exist files not in this list (or the other way
round) repacking must be triggered regardless of timestamps.