Issue 48949 - method <SwDoc::CopyPageDesc(..)> creates invalid undo action
Summary: method <SwDoc::CopyPageDesc(..)> creates invalid undo action
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 680m100
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on: 46909
Blocks:
  Show dependency tree
 
Reported: 2005-05-09 13:15 UTC by Oliver-Rainer Wittmann
Modified: 2013-08-07 14:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver-Rainer Wittmann 2005-05-09 13:15:29 UTC 
The method <SwDoc::CopyPageDesc(..)> creates the invalid undo action 'Insert:
frame|draw object', if the page style contains a page header/footer, which
contains a floating screen object (frame, graphic, drawing object or OLE object).
This causes a crash or an inconsistent document, if such an invalid undo action
is performed followed by other correct undo actions.
E.g.: 
(1) open document <oat-2004.odt> attached to issue 46941 and change the margin
of the page -> Undo stack contains undo action 'Insert draw object'.
(2) copy a page style of above given type from a document A to a document B,
after you had inserted and deleted some paragraphs in document B -> Undo stack
contains undo action 'Insert draw object' --> trying to undo all actions causes
the Writer to crash
Comment 1 Oliver-Rainer Wittmann 2005-05-10 09:32:11 UTC 
proposed solution:
ad (1): suppress creation of undo action in method
<SwDocStyleSheet::SetItemSet(..)> in the case of changing a page style.
ad (2): suppress creation of undo actions for method <SwDocShell::Insert(..)>
and clear the undo action stack afterwards.

Note: solutions depend on fix for issue 46909
Comment 2 Oliver-Rainer Wittmann 2005-05-10 09:38:30 UTC 
fixed in cws swqbugfixes30 - changed files:
/sw/source/ui/app/docstyle.cxx, 1.18.114.1
/sw/source/ui/app/docsh2.cxx, 1.75.54.1
Comment 3 Oliver-Rainer Wittmann 2005-05-31 08:16:17 UTC 
OD->MRU:
Checked in internal installation set of cws swqbugfixes30 - please verify.

re-open issue and reassign to mru@openoffice.org
Comment 4 Oliver-Rainer Wittmann 2005-05-31 08:16:32 UTC 
reassign to mru@openoffice.org
Comment 5 Oliver-Rainer Wittmann 2005-05-31 08:16:44 UTC 
reset resolution to FIXED
Comment 6 michael.ruess 2005-06-07 13:57:46 UTC 
Verified fix in CWS swqbugfixes30.
Comment 7 Oliver-Rainer Wittmann 2005-06-28 13:00:35 UTC 
Reopen, because cws swqbugfixes30 will be canceled.
Fix will be integrated into cws swqbf34
Comment 8 Oliver-Rainer Wittmann 2005-06-28 13:04:59 UTC 
fixed in cws swqbf34 - changed files:
/sw/source/ui/app/docstyle.cxx, 1.18.186.1
/sw/source/ui/app/docsh2.cxx, 1.75.132.1
Comment 9 Oliver-Rainer Wittmann 2005-06-29 11:36:27 UTC 
fix reviewed by FME.
Comment 10 Oliver-Rainer Wittmann 2005-07-04 08:41:46 UTC 
OD->MRU:
Checked in internal installation set of cws swqbf34 - please verify.
Comment 11 michael.ruess 2005-07-06 12:40:06 UTC 
Corrected "Target Milestone" to OO 2.0.
Comment 12 michael.ruess 2005-07-06 12:59:13 UTC 
Verified fix in CWS swqbf34.
Comment 13 michael.ruess 2005-07-22 16:10:30 UTC 
Checked fix in 680m119.