Issue 49461 - A continued comment line is hiding the next makefile statement ..
Summary: A continued comment line is hiding the next makefile statement ..
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-18 15:28 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2005-05-18 15:28:55 UTC 
A continued comment line is hiding the next makefile statement even though there
are empty lines between the commented line and the comment.

Example makefile.mk:

AAA:=hallo

# xxxxxxxxxxxxxxxxxxx \

AAA+=xxx

all :
	+echo "X$(AAA)Y"



prints only "XhalloY"
Comment 1 hjs 2005-05-19 13:29:41 UTC 
found that vim syntax highlightening for *.mk works the same way!? but still
it's quite unintuitive...
Comment 2 quetschke 2005-05-19 20:53:27 UTC 
The man page says:
       A set of continued lines may
       be commented out by placing a single # at the start of the first  line.

So vim syntax highlightening has the same bug as the current dmake. The
following patch should fix this problem. (At least for dmake ;) )


+++ dmake/getinp.c      19 May 2005 19:40:38 -0000
@@ -181,6 +181,7 @@
       }
       else {  /* empty line or "" */
         cont = FALSE;
+        ignore = FALSE;
         q = p+strlen(p);  /* strlen(p) is 1 or 0 */
       }
Comment 3 hjs 2005-05-20 13:41:09 UTC 
with this patch dmake acts as expected, which is by the way the same as gnu make
handles it. please commit.
Comment 4 quetschke 2005-05-20 19:24:20 UTC 
Committed to CWS dmake43p01.
Comment 5 quetschke 2005-05-20 19:25:27 UTC 
> with this patch dmake acts as expected, which is by the way the same as gnu
> make handles it. please commit.

I see this as a verification.

->VERIFIED
Comment 6 quetschke 2006-11-01 18:33:36 UTC 
close