Issue 50092 - $(shell,XXX command) expands the result for all non-empty XXX
Summary: $(shell,XXX command) expands the result for all non-empty XXX
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-31 02:20 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for dmake (2.03 KB, patch)
2007-08-05 20:54 UTC, quetschke 		no flags Details | Diff
workarounds for solaris printf and nfs timing issues (2.52 KB, patch)
2007-10-11 12:10 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2005-05-31 02:20:49 UTC 
The check in _exec_shell in dmake/function.c expands the result if the parameter
to $(shell,para ...) is != "", but according to the man page only "expand" is a
valid parameter.
Comment 1 quetschke 2007-08-05 20:54:55 UTC 
Created attachment 47329 [details]
Patch for dmake
Comment 2 quetschke 2007-08-05 22:11:17 UTC 
Committed patch and testcase to dmake411.
Comment 3 quetschke 2007-08-05 22:11:55 UTC 
Please verify
Comment 4 hjs 2007-09-25 11:49:08 UTC 
only "expand" is accepted now
Comment 5 hjs 2007-09-25 12:10:52 UTC 
and a target
Comment 6 hjs 2007-10-11 12:10:32 UTC 
Created attachment 48833 [details]
workarounds for solaris printf and nfs timing issues
Comment 7 hjs 2007-10-11 12:13:35 UTC 
dmake worked fine but the testcase didn't on solaris. there seems to be a
problem with the printf binary. using the bash internal works fine but requires
additional quoting.
don't know if using bash in testcases is acceptable for you.
Comment 8 quetschke 2007-10-11 21:58:51 UTC 
Thanks for the patch - committed. No, I don't mind the bash requirement.
Comment 9 hjs 2007-12-21 13:51:50 UTC 
dmake 4.11 is in use now