Issue 51005 - remove sh-script code: obsolete which()
Summary: remove sh-script code: obsolete which()
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m109
Hardware: All Unix, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-20 17:40 UTC by flibby05
Modified: 2013-08-07 15:31 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch1 (627 bytes, patch)
2005-06-20 17:41 UTC, flibby05 		no flags Details | Diff
patch2 (650 bytes, patch)
2005-06-20 17:41 UTC, flibby05 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description flibby05 2005-06-20 17:40:24 UTC 
function which() should be obsolete, because external 'which' is run in:

--- shell/source/unix/misc/open-url.sh  2005-06-17 14:22:46.000000000 +0200

--- shell/source/unix/misc/senddoc.sh   2005-06-17 14:22:46.000000000 +0200
Comment 1 flibby05 2005-06-20 17:41:06 UTC 
Created attachment 27345 [details]
patch1
Comment 2 flibby05 2005-06-20 17:41:41 UTC 
Created attachment 27346 [details]
patch2
Comment 3 flibby05 2005-06-20 17:42:17 UTC 
attached 2 patches
Comment 4 flibby05 2005-06-20 17:43:12 UTC 
cosmetic
Comment 5 mci 2005-06-21 09:19:58 UTC 
reassigned to obr...

mci -> obr: 
Hi obr, 
as dicussed: this is one of th issues about browser-detection on UNIX/Linux...
Comment 6 nospam4obr 2005-06-21 10:05:52 UTC 
Hmm, /usr/bin/which is a csh script on Solaris, which unfortunatly sources
~/.cshrc. As soon as people do any terminal output in the cshrc, the result of a
call to /usr/bin/which is unpredictable.

Therefore I would prefer leaving those few lines of shell code in.
Comment 7 nospam4obr 2005-08-04 12:51:12 UTC 
This is too risky for a .0.x release - I also believe we should leave the code
in, adding a comment why this solution has been prefered over /usr/bin/which.
Comment 8 stx123 2006-03-20 07:55:53 UTC 
I think we should come to a decision how we would like to move forward with the
usage of which and the patch.
Changing target to "not determined" ...
Comment 9 nospam4obr 2006-03-20 13:00:20 UTC 
I still don't think using /usr/bin/which on Solaris is a good idea, so my take
on this would be to move the code to an extra scriptlet, that only gets packaged
and sourced by the other scripts on Solaris.
Comment 10 nospam4obr 2006-04-27 10:47:40 UTC 
Removing the "patch" flag until a new one get's attached - I can not accept the
attached, because they will cause regressions on Solaris.
Comment 11 nospam4obr 2007-11-15 08:21:46 UTC 
One option could be to use type -p or perl.
Comment 12 nospam4obr 2008-01-30 09:00:02 UTC 
The way OO.o opens a web browser or e-mail client has aged and needs some
rethinking. Unfortunately this won't be ready for OOo 3.0, so shifting this
issue to 3.x.
Comment 13 nospam4obr 2008-07-22 08:29:16 UTC 
maintainer changed.
Comment 14 Rob Weir 2013-07-30 02:39:43 UTC 
Reset assignee on issues not touched by assignee in more than 1000 days.