Issue 52377 - -D_USE_NAMESPACE and -D_USE_NAMESPACE=1
Summary: -D_USE_NAMESPACE and -D_USE_NAMESPACE=1
Status: CLOSED DUPLICATE of issue 52551
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: DevTools
Assignee: hjs
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-23 22:42 UTC by pavel
Modified: 2005-07-28 16:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-07-23 22:42:13 UTC 
Hi,

this is typical compile command like:

Making: ../../../unxlngi6.pro/slo/sddetect.obj
/home/oo/BuildDir/bin/ccache /disk2/OpenOffice.org/GCC341/bin/g++ -Wreturn-type
-fmessage-length=0 -c -I. 
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solver/680/unxlngi6.pro/inc/offuh
-I../inc -I../../../inc -I../../../unx/inc -I../../../unxlngi6.pro/inc -I.
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solver/680/unxlngi6.pro/inc/stl
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solver/680/unxlngi6.pro/inc/external
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solver/680/unxlngi6.pro/inc
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solenv/unxlngi6/inc
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solenv/inc
-I/home/oo/BuildDir/ooo_SRC680_m121_src/res
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solver/680/unxlngi6.pro/inc/stl
-I/home/oo/BuildDir/ooo_SRC680_m121_src/solenv/inc/Xp31
-I/usr/lib/SunJava2/include -I/usr/lib/SunJava2/include/linux
-I/usr/lib/SunJava2/include/native_threads/include -I/usr/X11R6/include     -I.
-I../../../res -I. -Os -fno-strict-aliasing -Wuninitialized  
-fvisibility=hidden -pipe -mtune=pentiumpro -Wno-ctor-dtor-privacy
-fvisibility-inlines-hidden -g -fexceptions -fno-enforce-eh-specs   -fpic
-DLINUX -DUNX -DVCL -DGCC -DC341 -DINTEL
-DGXX_INCLUDE_PATH=/disk2/OpenOffice.org/GCC341/lib/gcc/i686-pc-linux-gnu/3.4.1/../../../../include/c++/3.4.1
-DCVER=C341 -D_USE_NAMESPACE -DGLIBC=2 -DX86 -D_PTHREADS -D_REENTRANT
-DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400
-DHAVE_GCC_VISIBILITY_FEATURE -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DSUPD=680
-DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DEXCEPTIONS_ON
-DCUI -DSOLAR_JAVA -DSRC680   -DSD_DLLIMPLEMENTATION -DSHAREDLIB -D_DLL_ 
-DMULTITHREAD  -o ../../../unxlngi6.pro/slo/sddetect.o
/home/oo/BuildDir/ooo_SRC680_m121_src/sd/source/ui/unoidl/sddetect.cxx

There are both -D_USE_NAMESPACE and -D_USE_NAMESPACE=1. Why?

Shouldn't we remove this from settings.mk completely?
Comment 1 Olaf Felka 2005-07-27 10:47:29 UTC 
*** Issue 52538 has been marked as a duplicate of this issue. ***
Comment 2 hjs 2005-07-27 17:40:06 UTC 
i did a bit research around "_USE_NAMESPACE":
it's obsolete anyway but removing it would require about 150 files to be touched
(mostly svx, vos and binfilter) -> this is OOo later (#i52551#)

the duplicate define can be resolved by removing either of the additions. i
would suggest to keep the define in "settings.mk" and remove the others to avoid
inconsistencies between different platforms.

i will do this if there are no objections...
Comment 3 hjs 2005-07-27 17:40:55 UTC 
missed to set target...
Comment 4 pavel 2005-07-27 20:18:33 UTC 
It is not urgent at all and #i52551# will solve it -> I propose to mark this
issues as duplicate of the new issue. If you agree, please close this one :-)

The only effect of this is filling build logs.


*** This issue has been marked as a duplicate of 52551 ***
Comment 5 hjs 2005-07-28 16:07:52 UTC 
ok :-)