Issue 53466 - Patch for correct recognition of Dzongkha native digits in open office
Summary: Patch for correct recognition of Dzongkha native digits in open office
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-18 08:00 UTC by pema.geyleg
Modified: 2013-08-07 15:00 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to file numberchar.h (1.60 KB, patch)
2005-08-18 08:02 UTC, pema.geyleg 		no flags Details | Diff
Patches for two files numberchar.h and nativenumbersupplier.cxx (3.37 KB, patch)
2005-08-19 06:44 UTC, pema.geyleg 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pema.geyleg 2005-08-18 08:00:39 UTC 
Eike,

    I am attaching a patch for i18npool/source/nativenumber/data/numberchar.h
for including Dzongkha . 
   Right now [NatNum1] is not working for Dzongkha in Open office calc src680m123.
I asume that it is because of Dzongkha not in this file.
Comment 1 pema.geyleg 2005-08-18 08:02:03 UTC 
Created attachment 28873 [details]
Patch to file numberchar.h
Comment 2 ooo 2005-08-18 17:09:38 UTC 
Hi Pema,

Funny, you _assume_ that it works with your patch? Why didn't you _verify_ it?
It wouldn't work, at least the natnum1Locales[] and natnum1[] entries are
missing from i18npool/source/nativenumber/nativenumbersupplier.cxx. I admit
these should be grouped with the other tables in numberchar.h though for easier
handling.

Please attach a complete patch after having verified that it works! Then
reassign back to me.

Thanks
  Eike
Comment 3 pema.geyleg 2005-08-19 04:36:48 UTC 
Eike,

   The Dzongkha Locale submitted by Mr. Javier Sola has the NatNum1 support in it.
Dzongkha rendering works in Open office with the exception of using native
numbers in Open office Calc.
   At the moment, I have not been building oosrc 680 and I am not in the
position to check the patch.
   I just compared with the Khmer, which was working and I assumed that the
NatNum1 not working in calc is because of the file
i18npool/source/nativenumber/data/numberchar.h not having dz(and others) in it.
   I m really sorry for assuming things.
   At the moment I am not sure what would be the complete patch for solving this
issue.
   Is it that I have to create patch for
  1)i18npool/source/nativenumber/data/numberchar.h and
  2)i18npool/source/nativenumber/nativenumbersupplier.cxx
to have NatNum1 working for Dzongkha..
Could u throw some more light to this issue...

Many Thanks
Pema Geyleg
Comment 4 lists 2005-08-19 06:38:28 UTC 
My fault, actually.... adding this file to the documentation...
Comment 5 pema.geyleg 2005-08-19 06:44:36 UTC 
Created attachment 28915 [details]
Patches for two files numberchar.h and nativenumbersupplier.cxx
Comment 6 pema.geyleg 2005-08-19 06:49:26 UTC 
A patch for the two files:
   1)i18npool/source/nativenumber/data/numberchar.h
   2) i18npool/source/nativenumber/nativenumbersupplier.cxx

This patch hopes to enable NatNum1 (native number) for Dzongkha in Open Office calc

Pema Geyleg
Comment 7 ooo 2005-08-22 12:27:33 UTC 
Hi Pema,

Looks better :-)
Though in general I prefer patches that are verified to work, this one is
simple, and I can just assume that the glyphs displayed are actually those
intended..

Thanks
  Eike
Comment 8 ooo 2005-08-22 17:59:02 UTC 
On branch cws_src680_localedata6

i18npool/source/nativenumber/nativenumbersupplier.cxx 1.19.4.1
i18npool/source/nativenumber/data/numberchar.h 1.8.4.1
Comment 9 ooo 2005-08-23 12:43:35 UTC 
Reassign to QA.

re-open issue and reassign to oc@openoffice.org
Comment 10 ooo 2005-08-23 12:43:48 UTC 
reassign to oc@openoffice.org
Comment 11 ooo 2005-08-23 12:43:55 UTC 
reset resolution to FIXED
Comment 12 oc 2005-08-24 15:02:39 UTC 
verified in internal build cws_localedata6
Comment 13 oc 2005-09-29 11:07:31 UTC 
closed because fix available in OOo1.9m131