Apache OpenOffice (AOO) Bugzilla – Issue 55055
Simplify/clarify pythonscript.py code
Last modified: 2013-12-18 09:38:39 UTC
Throughout this module this line is used many times: log.isDebugLevel() and log.debug("blahblah...") The first part is already included in the log.debug function. It is much simpler to read and faster to execute if the code is simplified as: log.debug("blahblah...") This happens 27 times including 2 commented lines. Very easy to change with a "replace all".
TM->requirements: Please have a look.
OpenOffice.org Issue Tracker - Feedback Request. The Issue you raised is currently assigned to 'Requirements' pending review, but has not been updated within the last 2+ years. Please consider re-testing with one of the latest versions of OOo, as the problem(s) may have already been addressed. Either use the recent stable version: http://download.openoffice.org/index.html or consider trying the new OOo 3 BETA (still in testing): http://download.openoffice.org/3.0beta/ Please report back the outcome so this Issue may be Closed or Progressed as necessary - otherwise it may be Resolved as Invalid in the future. You may also wish to search for (and note) any duplicates of this Issue that may have advanced further by checking the Issue Tracker: http://www.openoffice.org/issues/query.cgi Many thanks, Andrew Cleaning-up and Closing old Issues as part of: ~ The Grand Bug Squash, pre v3 ~ http://marketing.openoffice.org/3.0/announcementbeta.html
This coding has not changed on pythonscript.py source for OOo version 2.4.0 Of course it is not incorrect, only more complex and slow than necessary. And very easy to change.
Created attachment 78450 [details] Proposed patch to fix this issue Fix as report, remove "log.isDebugLevel() and " part from these lines.
Committed revision 1366950. Sorry it took so long and thank you for your contribution!