Issue 56253 - Undo does not restore "restart numbering at this paragraph" property
Summary: Undo does not restore "restart numbering at this paragraph" property
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: editing (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-19 07:49 UTC by kristov
Modified: 2013-08-07 14:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description kristov 2005-10-19 07:49:21 UTC
Problem: If you use a numbering on a series of paragraphs (either manually
assigned or through a paragraph style), and you marked one of these paragraphs
with the "restart numbering at this paragraph" property, and you switch the
numbering off (e.g. with the button in the tool bar), a subsequent undo does not
restore that very property.

How to reproduce [I use the german localization, so some translations might be
inaccurate]:
1) Create an empty document.
2) Type some paragraphs (at least two), e.g.
   A
   B
3) Apply any numbering to both of them simulateously, e.g. via the "Switch
numbering on/off" button in the tool bar. You receive something like:
   1. A
   2. B
4) Select the second paragraph, open the paragraph property dialogue, go the the
"Numbering" tab and activate the "restart numbering at this paragraph" option.
Confirm the dialogue. No you receive something like:
   1. A
   1. B
5) Now select the whole document and switch the numbering off, such that you
receive again:
   A
   B
6) If you now perform an undo operation (e.g. via Ctrl-Z), you receive:
   1. A
   2. B
That means that the setting "Restart numbering at this paragraph" is not restored.

This applies to OpenOffice.org 2.0RC3.
Comment 1 michael.ruess 2005-10-20 15:53:35 UTC
MRU->OD: two numbered paragraphs, second has "restart with 1". Switch numbering
of for both, Undo -> "restart" attribute is not restored

This looks fixed in CWS swnumtree, so could you please add the task there or
give an appropriate duplicate ID by time? Thanks a lot.
Comment 2 Oliver-Rainer Wittmann 2005-10-21 12:40:31 UTC
Looks good to me in cws swnumtree, too. Thus, adding this task to cws swnumtree.
Comment 3 Oliver-Rainer Wittmann 2005-10-27 09:00:16 UTC
OD->MRU: Looks good in internal installation set of cws swnumtree, too - please
verify.

re-open issue and reassign to mru@openoffice.org
Comment 4 Oliver-Rainer Wittmann 2005-10-27 09:00:20 UTC
reassign to mru@openoffice.org
Comment 5 Oliver-Rainer Wittmann 2005-10-27 09:00:24 UTC
reset resolution to FIXED
Comment 6 michael.ruess 2005-10-28 15:51:55 UTC
Verified fix in CWS swnumtree.
Comment 7 michael.ruess 2005-11-11 12:13:53 UTC
Unfortunately issue will still occur. Reopened issue to fix in OO 2.0.2.
Comment 8 michael.ruess 2005-11-11 12:14:45 UTC
Reassigned to OD to fix it in OO 2.0.2.
Comment 9 Oliver-Rainer Wittmann 2005-12-07 14:36:26 UTC
Investigation reveals that the restarting of numbering isn't recorded in the undo.
Comment 10 michael.ruess 2005-12-07 15:20:09 UTC
Due to lack of resources, this is retargeted to OO 3.0.
Comment 11 Oliver-Rainer Wittmann 2006-06-23 13:03:18 UTC
adjust target milestone to 2.x
Comment 12 Oliver-Rainer Wittmann 2006-11-14 09:41:00 UTC
accepted to be fixed for OOo 2.2. Thus, adjusting target.
Comment 13 Oliver-Rainer Wittmann 2006-12-06 13:16:32 UTC
fixed in cws swqbf90 - changed files:
/sw/source/core/docnode/node.cxx, 1.30.14.1
/sw/source/ui/shells/textsh1.cxx, 1.52.88.1
Comment 14 Oliver-Rainer Wittmann 2007-01-04 09:20:11 UTC
reopen issue, because of the following reasons:
- proposed fix doesn't work any more due to changes made in cws swautomatic01,
integrated into SRC680m196
- proposed fix doesn't work, if list style is set via paragraph style and
numbering switch off by removing list style from paragraph style
Comment 15 Oliver-Rainer Wittmann 2007-01-04 09:47:54 UTC
If list style is set via paragraph style, the undo doesn't work regardless how
the numbering is switched off - removing list style from paragraph style,
removing list style from paragraph, using the toolbar numbering on/off button, ...
Comment 16 Oliver-Rainer Wittmann 2007-01-10 09:37:36 UTC
due to limited resources I have to re-target this issue to OOo 2.3
Comment 17 Oliver-Rainer Wittmann 2007-07-12 11:56:29 UTC
fixed in cws swqbf101 - changed files:
/sw/inc/undobj.hxx, 1.33.8.1
/sw/source/core/undo/unattr.cxx, 1.14.128.1
/sw/source/core/doc/docfmt.cxx, 1.44.98.1

/sw/inc/rolbck.hxx, 1.7.396.2
/sw/source/core/undo/rolbck.cxx, 1.18.288.2
/sw/source/core/undo/undel.cxx, 1.21.68.1
/sw/source/core/undo/unins.cxx, 1.26.94.1
/sw/source/core/undo/unmove.cxx, 1.8.288.1
/sw/source/core/undo/unsect.cxx, 1.13.288.1
/sw/source/core/undo/untbl.cxx, 1.31.6.1
/sw/source/core/undo/untblk.cxx, 1.9.288.1
/sw/source/core/doc/docnum.cxx, 1.66.94.1
/sw/source/core/attr/cellatr.cxx, 1.4.376.1
Comment 18 Oliver-Rainer Wittmann 2007-07-13 12:25:12 UTC
Note for the QA:
Please check undo and redo actions regarding numbering/bullets.
Comment 19 andreas.martens 2007-07-19 14:07:33 UTC
Ready for QA.
Comment 20 michael.ruess 2007-07-23 12:34:43 UTC
Verified fix in CWS swqbf101.
Comment 21 michael.ruess 2007-07-23 12:35:53 UTC
Reopened, should have been set to "Verified".
Comment 22 michael.ruess 2007-07-23 12:37:00 UTC
.
Comment 23 michael.ruess 2007-07-23 12:39:21 UTC
.
Comment 24 michael.ruess 2007-07-30 14:22:04 UTC
Checked in 680m223.