Issue 58248 - fixing future potential mt problem in Weak[Agg]ComponentHelperBase::release()
Summary: fixing future potential mt problem in Weak[Agg]ComponentHelperBase::release()
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.3
Assignee: Stephan Bergmann
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-21 14:21 UTC by Daniel Boelzle [:dbo]
Modified: 2006-03-10 09:17 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Daniel Boelzle [:dbo] 2005-11-21 14:21:16 UTC 
Currently the reference count in Weak[Agg]ComponentHelperBase is checked
unlocked which is atomar for all current platforms, but may raise problems in
the future.
Comment 1 Daniel Boelzle [:dbo] 2005-11-21 15:09:17 UTC 
.
Comment 2 Daniel Boelzle [:dbo] 2005-11-21 15:34:50 UTC 
fixed.
Comment 3 Daniel Boelzle [:dbo] 2005-11-28 12:39:28 UTC 
@SB: please verify on cws02/dbo510, cppuhelper/source/implbase.cxx. thank you.


re-open issue and reassign to sb@openoffice.org
Comment 4 Daniel Boelzle [:dbo] 2005-11-28 12:39:32 UTC 
reassign to sb@openoffice.org
Comment 5 Daniel Boelzle [:dbo] 2005-11-28 12:39:37 UTC 
reset resolution to FIXED
Comment 6 Stephan Bergmann 2005-11-30 16:53:01 UTC 
In both implbase.cxx and weak.cxx, "(void) exc; // avoid warning about unused
variable" at the start of a block would probably be more idiomatic than
"static_cast<void>(exc);" at the end of a block.  And you did run any relevant
tests, I assume.
Comment 7 joerg.skottke 2006-03-06 07:39:21 UTC 
set target
Comment 8 joerg.skottke 2006-03-06 07:43:55 UTC 
set target again
Comment 9 Stephan Bergmann 2006-03-10 09:17:07 UTC 
.