Issue 58947 - 64bit: svx: resids are 32bit *always*
Summary: 64bit: svx: resids are 32bit *always*
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.2
Assignee: pavel
QA Contact: issues@framework
URL: http://go-oo.org/patches/64bit/buildf...
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-06 11:21 UTC by pavel
Modified: 2006-01-30 21:47 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-12-06 11:21:46 UTC 
Hi,

the function GalleryResGetBitmapEx is declared and defined as:

BitmapEx GalleryResGetBitmapEx( ULONG nId )

Its argument is used in ResId constructor.

ResId is using it as a value for:

sal_uInt32		nResId; 	   // Resource Identifier

Please unify to sal_uInt32 instead of ULONG.

Kendy prepared this patch:

http://go-oo.org/patches/64bit/buildfix-64bit-svx.diff

Please ignore the second (empty) part (file svx/inc/outliner.hxx).

The above patch also removes unneccessary casting.

We have a cws for it (pj34), please review.
Comment 1 pavel 2005-12-06 11:53:32 UTC 
.
Comment 2 clippka 2005-12-06 12:04:05 UTC 
review done, please feel free to commit the patch
Comment 3 pavel 2005-12-06 12:29:48 UTC 
Patch is in pj43 now.

Please verify,
Comment 4 kendy 2005-12-06 14:13:33 UTC 
Seen in pj43, thank you!
Comment 5 pavel 2006-01-30 21:46:43 UTC 
Seen in SRC680_m154.
Comment 6 pavel 2006-01-30 21:47:02 UTC 
*** Issue 61235 has been marked as a duplicate of this issue. ***