Issue 58949 - 64bit: svx: debugging and 64bit issues
Summary: 64bit: svx: debugging and 64bit issues
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.2
Assignee: pavel
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-06 11:51 UTC by pavel
Modified: 2006-12-06 11:53 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Make svx compile even with DEBUG on AMD64 (2.31 KB, patch)
2005-12-06 11:52 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-12-06 11:51:39 UTC
Hi,

if debugging is enabled, new code is revealed. Several issues are there:

1. /data/oo/BuildDir/ooo_SRC680_m143_src/svx/source/dialog/tpline.cxx: In member
function 'virtual void SvxLineTabPage::Reset(const SfxItemSet&)':
/data/oo/BuildDir/ooo_SRC680_m143_src/svx/source/dialog/tpline.cxx:993: error:
cast from 'SvxLineTabPage*' to 'sal_Int32' loses precision

This is SVX_TRACE( 213, aStr );. SVX_TRACE contains:

    _aStr.Append( ByteString::CreateFromInt32( (sal_Int32) this ) );

ie. retyping pointer (64bit) to 32bit. Can we change this into

_aStr.Append( ByteString::CreateFromInt64( (sal_IntPtr) this ) );

2. /data/oo/BuildDir/ooo_SRC680_m143_src/svx/source/form/fmtextcontrolshell.cxx:
In member function 'void svx::FmTextControlShell::formActivated(const
com::sun::star::uno::Reference<com::sun::star::form::XFormController>&)':
/data/oo/BuildDir/ooo_SRC680_m143_src/svx/source/form/fmtextcontrolshell.cxx:1150:
error: cast from 'com::sun::star::form::XFormController*' to 'sal_Int32' loses
precision

      sTrace += ::rtl::OString::valueOf( (sal_Int32)_rxController.get(), 16 );

should be sal_IntPtr instead. There are more instances of this problem in this file.

See the attached file for complete patch.
Comment 1 pavel 2005-12-06 11:52:10 UTC
Created attachment 32129 [details]
Make svx compile even with DEBUG on AMD64
Comment 2 pavel 2005-12-06 11:52:52 UTC
Sorry, I forgot our prefix.
Comment 3 clippka 2005-12-06 12:08:14 UTC
review done, please feel free to commit the patch
Comment 4 pavel 2005-12-06 12:45:04 UTC
Patch is in pj43 now.

Please verify (you need to enable debugging for module svx at least).
Comment 5 kendy 2005-12-07 14:50:05 UTC
Verified in pj43.
Comment 6 pavel 2006-12-06 11:53:17 UTC
.