Issue 59226 - Slot: ToolsCustomize executed by testtool opens dialog with a tabpage missing
Summary: Slot: ToolsCustomize executed by testtool opens dialog with a tabpage missing
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.2
Assignee: joerg.skottke
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-12 08:52 UTC by joerg.skottke
Modified: 2006-02-21 07:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description joerg.skottke 2005-12-12 08:52:03 UTC
Automated test: framework\update\f_updt_customize.bas::tUpdtCustomize

When the testtool triggers the slot "ToolsCustomize" the expected dialog opens
but displays only three of the four tabpages. The Keyboard-Page is missing.

Travelling through the menu tools->customize... manually opens the dialog with
the correct number of tabs.
Comment 1 carsten.driesner 2005-12-12 10:22:46 UTC
cd: Started.
Comment 2 joerg.skottke 2006-01-11 13:29:44 UTC
There is no workaround, using testtool to travel through the menu and triggering
.uno:ConfigureDialog doesn't work either. :(
Comment 3 joerg.skottke 2006-01-11 14:55:12 UTC
If the dialog comes up with only three items, it will crash from time to time.
Apparently there is the possibility to restart the office before excuting the
test which makes all four pages appear - usually (There are exeptions) ...
Comment 4 carsten.driesner 2006-01-24 15:32:22 UTC
cd: Fixed. The dialog also used the getActiveFrame() method to retrieve the
active frame which is used identify the module. As this method is focus
dependent it could sometimes provide the wrong frame. This resulted in the magic
disappearance of the "keyboard" tab page. Now the dialog uses the provided
frame, which is always correct to identify the module.
Comment 5 carsten.driesner 2006-01-25 08:12:33 UTC
cd->jsk: Please verify this fix.

re-open issue and reassign to jsk@openoffice.org
Comment 6 carsten.driesner 2006-01-25 08:12:39 UTC
reassign to jsk@openoffice.org
Comment 7 carsten.driesner 2006-01-25 08:12:46 UTC
reset resolution to FIXED
Comment 8 carsten.driesner 2006-01-25 08:26:26 UTC
cd->jsk: Please check the customize dialog with all application modules
(including bibliography, start module, database ) to be sure that nothing has
been broken. 
Comment 9 joerg.skottke 2006-02-02 15:04:50 UTC
Fixed but failed - using fwk29 based on src680m154 (Linux).
The tabpage is still missing/missing again.

re-open issue and reassign to as@openoffice.org
Comment 10 joerg.skottke 2006-02-02 15:05:03 UTC
reassign to as@openoffice.org
Comment 11 joerg.skottke 2006-02-02 15:05:14 UTC
reset resolution to FIXED
Comment 12 joerg.skottke 2006-02-02 15:07:34 UTC
To "New"
Comment 13 joerg.skottke 2006-02-02 17:42:05 UTC
When opening the Tools/Customize dialog via "Assign..." button in Basic Macro
Organizer the tabpage is missing as well. 

Relevant autotests:
f_updt_customize.bas
f_basic_first.bas
Comment 14 andreas.schluens 2006-02-03 09:54:30 UTC
AS->JSK:
Sorry ... but this is a "following task" reasoned by fixing this one here.
Before it was not clear which frame was used by the dialog as context frame. If you 
e.g. had open two different frames (calc & writer) it was not clear, which of these 
frames was the last active one.

Now the frame must be specified explicit to this dialog ... but especialy this dialog 
does not provide the right frame. But that's true for the normal UI too (not only for 
the test tool).

On the other side it can happen that the keyboard tab page is missing inside this 
dialog even if we fix it. Please have look on the following scenario:

a)
-open backing mode
- "Tools->Macros->Organize Macros...->Assign"
=> Keyboard tab page will be missing (because it was decided not showing any 
keyboard tabe page for the backing mode !

b)
-open writer
- "Tools->Macros->Organize Macros...->Assign"
=> Keyboard tab page will be available.

=> Your test must check the current context to know if these tabpage (keyboard) 
must be available or not.

As discussed: Please file a follow-up task (set to target PP3 or Later).
But this task here must be accepted as works as designed currently.
Comment 15 andreas.schluens 2006-02-03 09:55:04 UTC
.
Comment 16 joerg.skottke 2006-02-07 06:44:31 UTC
Verified, all four tabs are present where expected (not from backing window, not
from macro organizer)
Comment 17 joerg.skottke 2006-02-21 07:45:35 UTC
Closed