Issue 61056 - Add X11 check on start
Summary: Add X11 check on start
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: OOo 2.0.1
Hardware: Mac Mac OS X, all
: P2 Trivial with 1 vote (vote)
Target Milestone: OOo 2.2
Assignee: shaunmcdonald131
QA Contact: issues@porting
Keywords: oooqa
Depends on:
Reported: 2006-01-23 15:32 UTC by shaunmcdonald131
Modified: 2008-05-16 03:32 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

A basic overview about X11 and why it needs to be installed (1.86 KB, text/rtf)
2006-01-23 15:42 UTC, shaunmcdonald131
no flags Details
Fix the X11 help message, open url to help page when "More Info" is chosen. Patch ready for integration and testing. (1.22 KB, patch)
2006-11-10 10:10 UTC, moxfox
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description shaunmcdonald131 2006-01-23 15:32:31 UTC
It would seem that the script main script within the droplet for the Mac OS X
build of OOo2 has had a debug line that was commented out for use in testing
when a XServer was not available. 

I would like to propose that this line to be expanded, to be more meaningful to
most users, to give them a explanation of why they cannot run OOo on the Mac,
and what they can do to run OOo on the Mac.

Look for "
	if whichserver = "NOXSERVER" then
		--display dialog "No XServer Found"
		set now_running to "Skip"
	end if

And change it to "
 	if whichserver = "NOXSERVER" then
		display dialog "No XServer Found, to find out more click More Info" buttons
{"Quit", "More Info"} default button "More Info" cancel button "Quit" with icon stop
		--open a file about How to install X11
		set myPath to (path to me)
		set aboutX11Path to POSIX path of myPath & "Contents/Resources/AboutX11.rtf"
		--display dialog aboutX11Path
		--We need the quotes in the name to prevent problems with spaces.
		do shell script "open " & "\"" & aboutX11Path & "\""
		set now_running to "Skip"
	end if

In here I am also proposing to have a small document, in my minor test I used a
very basic RTF that I will attach. I simply used it from point of principle. You
can use and document type and place it anywhere in the .app bundle.

To check that the script work I renamed X11 to X11t and then ran the update
locate database script (see bottom of man locate, and remember to use root).
Comment 1 shaunmcdonald131 2006-01-23 15:42:30 UTC
Created attachment 33480 [details]
A basic overview about X11 and why it needs to be installed
Comment 2 moxfox 2006-01-24 18:36:20 UTC
The launcher script is already being worked on IZ 57252. Adding this bug as a
Comment 3 stx123 2006-06-09 11:33:36 UTC
Issue 57252 is fixed. If the change proposed here is still valid I would
recommend to work with ericb2 or mox so that it's confirmed and started...
Comment 4 shaunmcdonald131 2006-06-09 12:11:43 UTC
The current status of this is issue is that with the latest builds if OOo cannot find X11, then it will display 
the localised error message, which in English says " cannot be started, because X11 is not 
installed. Please install Apple X11 first."

Ideally there would be some file that would open with information on installing Apple's X11.
Comment 5 pavel 2006-08-23 18:22:33 UTC
This is not PATCH issue.

We can close it now anyway...
Comment 6 jjmckenzie 2006-08-23 18:27:31 UTC

Maybe an Enhancement?  Mainly the localisation effort.

James M.
Comment 7 shaunmcdonald131 2006-08-24 09:07:55 UTC
This has been partially implemented so far.

There is an issue with the localisation on the text that goes into the current dialog. This is an issue with 
the string under 10.3.x in Applescript, but not 10.4.x

I also would like to have some link to more information as well, compared to the current implementation.
Comment 8 pavel 2006-08-25 08:33:45 UTC
Localisation issue should be filled as separate issue, probably.

Comment 9 jjmckenzie 2006-11-09 14:40:20 UTC
This issue is in progress.  There is a problem with supporting Panther (10.3) 
as imbedded strings are not read from the script.

James McKenzie
Comment 10 moxfox 2006-11-10 10:10:32 UTC
Created attachment 40489 [details]
Fix the X11 help message, open url to help page when "More Info" is chosen. Patch ready for integration and testing.
Comment 11 eric.bachard 2006-12-22 19:21:35 UTC

Your patch applies perfectly. m197 X11 is built, and I'll test on a machine without anything X11.

If nothing's wrong, I'll add it into macosx22fixes cws

Comment 12 eric.bachard 2006-12-28 09:46:57 UTC
Fixed in macosx22fixes (I'll complete the cws issue list asap )
Comment 13 moxfox 2006-12-28 11:02:53 UTC
I have verified that the changes are correct in CWS macosx22fixes.
Comment 14 pavel 2007-01-06 00:31:09 UTC
verified as well.
Comment 15 ace_dent 2008-05-16 03:32:30 UTC
This Issue is 'Verified' and not updated in 1yr+, so Closing.
A Closed Issue is a Happy Issue (TM).

Cleaning-up and Closing old Issues as part of:
~ The Grand Bug Squash, pre v3 ~