Issue 62430 - 64bit: mismatch between set and get RowTranslation
Summary: 64bit: mismatch between set and get RowTranslation
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: PC (x86_64) All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: caolanm
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-22 12:49 UTC by caolanm
Modified: 2013-02-24 21:21 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
workaround patch (1.12 KB, patch)
2006-02-22 12:49 UTC, caolanm 		no flags Details | Diff
patch for review (8.58 KB, patch)
2006-03-15 10:20 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2006-02-22 12:49:25 UTC 
SetRowTranslation uses sal_Int32*, while GetRowTranslation uses long*, which are
currently the same for 32bit, but are different for 64bit. 

defined in sch/memchrt.hxx

A patch attached to translate as things currently are in sc where it is used,
but which way do you want this fixed, both long*, or both sal_Int32* ?
Comment 1 caolanm 2006-02-22 12:49:44 UTC 
Created attachment 34378 [details]
workaround patch
Comment 2 kla 2006-02-24 14:37:32 UTC 
@bm: I think its for you.
Comment 3 caolanm 2006-03-15 10:20:29 UTC 
Created attachment 34890 [details]
patch for review
Comment 4 caolanm 2006-03-15 10:21:32 UTC 
how about this as the final preferred solution ? Make consistently use
sal_Int32, i.e. no change at all from current implied 32bit situation.

If you're ok with this change, return it to me and I can take care of committing it.
Comment 5 bjoern.milcke 2006-03-15 10:29:58 UTC 
-> cmc: Sorry, for not taking care of this issue. As we are re-writing the
chart, I am a bit lazy about issues concerning sch.
Well, the inconsistent usage of different types (sal_Int32, long, USHORT, short,
...) in the chart has always been a pain, but never enough of a pain to fix it ...
Your patch looks good. If you take care about committing the changes, that would
be great. Go ahead, and thanks!
Comment 6 bjoern.milcke 2006-03-15 10:31:44 UTC 
One additional comment: Did you make sure that this stuff is not used in Writer?
It might also be used there, but I am not sure about this. (I suppose you
checked, anyway)
Comment 7 caolanm 2006-03-15 11:02:35 UTC 
excellent, committed to sixtyfour04, writer is ok from this perspective.
Comment 8 pavel 2006-04-04 07:38:11 UTC 
Verified.
Comment 9 caolanm 2006-04-13 14:09:24 UTC 
in m163