Issue 62514 - Add Tajik_Tajikistan (tg_TJ) locale data
Summary: Add Tajik_Tajikistan (tg_TJ) locale data
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: localedata (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-24 05:29 UTC by chiafkarem
Modified: 2013-08-07 15:01 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Tajik locale data tg-TJ.XML file (14.19 KB, text/xml)
2006-02-27 04:06 UTC, chiafkarem
no flags Details
Patch for Tajik language inclusion (langtab.src) (610 bytes, text/plain)
2006-03-15 10:58 UTC, chiafkarem
no flags Details
Tajik locale file (corrected) (14.68 KB, text/xml)
2006-03-16 08:28 UTC, chiafkarem
no flags Details
Thousands/decimal separator corrected (14.68 KB, text/xml)
2006-03-17 04:26 UTC, chiafkarem
no flags Details
Corrected tg-TJ.xml (14.68 KB, text/xml)
2006-03-17 12:05 UTC, chiafkarem
no flags Details
Corrections for tg_TJ.xml (14.68 KB, text/xml)
2006-04-05 05:41 UTC, chiafkarem
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description chiafkarem 2006-02-24 05:29:23 UTC
Please include Tajik language into Locale Setting dialog box.
Comment 1 simos.bugzilla 2006-02-25 04:46:01 UTC
Is there a Tajik locale file for OpenOffice.org already available?
Comment 2 chiafkarem 2006-02-27 04:06:25 UTC
Created attachment 34464 [details]
Tajik locale data tg-TJ.XML file
Comment 3 chiafkarem 2006-02-27 04:07:54 UTC
Yes, we have Tajik locale data file. Please find attached.

Thanks,
Murod
Comment 4 simos.bugzilla 2006-02-27 14:07:07 UTC
Ok, the steps you should be following are outlined at
http://translate.sourceforge.net/doc/project-openoffice.html

This report is marked as an ENHANCEMENT and now it includes a tg-TJ.xml locale
file, which is good.

By the way, add your details at
http://l10n.openoffice.org/languages.html
According to the page, send an e-mail to Pavel Janik. This way, if anyone else
is interested in Tajik OpenOffice, they will be contacting you.
Comment 5 chiafkarem 2006-03-15 10:58:21 UTC
Created attachment 34894 [details]
Patch for Tajik language inclusion (langtab.src)
Comment 6 stx123 2006-03-15 11:12:19 UTC
reassigning...
Comment 7 ooo 2006-03-15 14:03:13 UTC
Sorry, but the attached locale data file doesn't even pass an XML validation,
also after changing all "TRUE" to "true" and "FALSE" to "false" there remain
about 20 errors. Please try with the service available at
http://www.validome.org/ and correct the errors and attach the corrected file to
this issue. When done, please reassign it to me ('er').

Btw, Mircha, what is your full name and did you sign the JCA? Without that we
can't include your contribution, please see
http://contributing.openoffice.org/programming.html#jca

Thanks
  Eike
Comment 8 chiafkarem 2006-03-16 08:28:18 UTC
Created attachment 34918 [details]
Tajik locale file (corrected)
Comment 9 chiafkarem 2006-03-16 08:32:35 UTC
Hello,
Yes, I have submitted JCA much earlier. I suddenly discovered that locale file
is not valid. I actually generated it using tool from
http://www.it46.se/localegen and submitted without checking. 
Thanks,

My full name is Murod Latifov A.
Comment 10 ooo 2006-03-16 11:13:53 UTC
Hi Murod,

> I suddenly discovered that locale file is not valid. I actually
> generated it using tool from http://www.it46.se/localegen and
> submitted without checking.

Which actually makes me wonder because http://www.it46.se/localegen
lists a tg_TJ locale
http://www.it46.se/localegen/locale/1140753715_tg_TJ.xml created on
Feb24 by you that is completely different from your's attached to this
issue, it has different separators and different data, passes XML
validation and compiles. Your data now passes validation, but building
it results in:

parsing document tg_TJ started
Warning: ThousandSeparator is an ' ' ordinary space, this should be a
non-breaking space U+00A0 instead.Warning: Don't forget to adapt FormatCode
elements when changing separators.
Error: ThousandSeparator not present in FormatCode formatindex="4".
Warning: formatindex="4","44","45" are the only FormatCode elements checked,
there may be others that have errors.
Error: in data for tg_TJ: 1
parsing document tg_TJ finished

The error is because the ThousandSeparator defined is the ordinary
space, but used in the number formats is the correct non-breaking space.

Please clarify what the correct data would be.

  Eike
Comment 11 chiafkarem 2006-03-17 04:26:13 UTC
Created attachment 34946 [details]
Thousands/decimal separator corrected
Comment 12 ooo 2006-03-17 11:23:46 UTC
Now the format codes don't match the separators defined:

parsing document tg_TJ started
Warning: DecimalSeparator is different from Time100SecSeparator, this may be
correct or not.
Warning: Don't forget to adapt FormatCode elements when changing separators.
Error: DecimalSeparator not present in FormatCode formatindex="4".
Error: Ordering of ThousandSeparator and DecimalSeparator not correct in
formatindex="4".
Warning: formatindex="4","44","45" are the only FormatCode elements checked,
there may be others that have errors.
Error: in data for tg_TJ: 2
parsing document tg_TJ finished

Furthermore, some of the currency format codes use [$р.-419] while some
others use [$с.-419]. The currency symbol used there and the one defined
with <Currency usedInCompatibleFormatCodes="true"> must be identical.
And the LCID number is wrong now, instead of 419 it must be 428.
All that was correct in the first version you submitted.

There are two Currency elements defined, both with CurrencyID TJS, the
default and usedInCompatibleFormatCodes="true" element says сом. would
be the CurrencySymbol, but that is not used in the FormatCode elements.
The other Currency element has с. as the CurrencySymbol. So which one is
it? There should be only one Currency element for a given currency. Btw,
BankSymbol should be identical to the CurrencyID ISO code.

trueWord and falseWord don't seem to be correct, they are
<trueWord>?а??он?</trueWord>
<falseWord>?албак?</falseWord>
and the question marks seem to result from some encoding error an editor
produced, probably not capable of UTF-8. Same for the two
<FollowPageWord>са?.</FollowPageWord>
elements. These encoding errors were not present in the first version, but
are already in the previous version.
Please also check the other elements like day and month names.

The best probably would be to start from scratch again using the locale
generator, which also takes care that the FormatCode elements match the
separators defined.

Btw, I'll be on vacation for two weeks, I may check back for this issue,
but don't expect answers before April.
Comment 13 chiafkarem 2006-03-17 12:05:05 UTC
Created attachment 34956 [details]
Corrected tg-TJ.xml
Comment 14 chiafkarem 2006-03-17 12:13:13 UTC
Hi,

We decided to shift back to space, this will remove current error, ignore error
for "space" in thousandsseparator. The rest is checked, and changed as was
instructed by you. '?' in са'ҳ' is - U+04b7, the other two '?'s are U+049b and
U+04e3. These are pure tajik characters, not supported by most unicode fonts. 

Please change <DateSeparator>/</DateSeparator> to
<DateSeparator>.</DateSeparator>. If validator gives error for space, then it
somehow should be 'space', maybe quotation marks with space inside? In case
space is not valid separator we will change it. 


thanks
Comment 15 ooo 2006-03-17 13:52:38 UTC
Hi Murod,

> We decided to shift back to space, this will remove current error,
> ignore error for "space" in thousandsseparator. The rest is checked, and
> changed as was instructed by you.

This is not a matter of removing an error, but what the correct data
would be. If the ThousandSeparator used with Tajik in Tajikistan is a
comma, then use that and adapt the format codes. If it is a space
indeed, fine.

> '?' in 'ҳ' is - U+04b7, the other two '?'s are U+049b and U+04e3.
> These are pure tajik characters, not supported by most unicode fonts.

This is not a font problem. The question marks I mentioned are literal
0x3f question marks, it is broken in the data submitted. Btw, also the
IndexKey element has a broken character there, and it occurs also in day
names, and also in the CurrencyName.

> Please change <DateSeparator>/</DateSeparator> to
> <DateSeparator>.</DateSeparator>.

Well, yes, I can do that, but why didn't you submit data that has it?

> If validator gives error for space, then it somehow should be 'space',
> maybe quotation marks with space inside? In case space is not valid
> separator we will change it.

I don't quite understand. Space where? The group (AKA thousand)
separator? Again: what is the correct separator that is used with Tajik
in Tajikistan? If it is a space, fine. Then it just should be the
non-breaking space U+00A0 instead of the ordinary space. That is already
used in the format codes, so just should also be defined as
ThousandSeparator element. That is what the warning is about.

Here the current compilation warnings and errors of the last data file
you submitted:

Warning: DecimalSeparator is different from Time100SecSeparator, this may be
correct or not.
Warning: ThousandSeparator is an ' ' ordinary space, this should be a
non-breaking space U+00A0 instead.
Warning: Don't forget to adapt FormatCode elements when changing separators.
Error: DecimalSeparator not present in FormatCode formatindex="4".
Error: ThousandSeparator not present in FormatCode formatindex="4".
Error: Ordering of ThousandSeparator and DecimalSeparator not correct in
formatindex="4".
Warning: formatindex="4","44","45" are the only FormatCode elements checked,
there may be others that have errors.
Error: in data for tg_TJ: 3

The DecimalSeparator is defined as dot '.' but the format codes use
comma ',' instead.

What about the Time100SecSeparator? It is defined as ',' and the format
code MM:SS,00 uses it, but should it really be different from
DecimalSeparator or is it just because also all other formats use ',' as
a decimal separator?
Comment 16 chiafkarem 2006-04-05 05:40:03 UTC
Hello,

I made new tg_TJ.xml from scratch. It is OK now, i made local build with no
error reported. I hope it works this time. This attachment will be named
050406tg_TJ.xml.
Comment 17 chiafkarem 2006-04-05 05:41:07 UTC
Created attachment 35503 [details]
Corrections for tg_TJ.xml
Comment 18 ooo 2006-04-11 13:58:10 UTC
Ah, yes, that looks much better and at least is syntactically correct.

Thanks
  Eike
Comment 19 chiafkarem 2006-05-22 06:33:22 UTC
Hello,

We submitted Tajik SDF file that was accepted for OOo 2.0.3, can we change
locale file target as well? 

Thanks,

Murod
Comment 20 ooo 2006-05-22 12:10:24 UTC
No, sorry, it's too late for 2.0.3. We already closed feature development
integration for this release. I didn't notice you had a Tajik UI localization
ready for this release and this issue could be related.
Comment 21 ooo 2006-06-02 22:51:47 UTC
In CWS locales204

i18npool/source/localedata/data/Attic/tg_TJ.xml  1.1.2.1
i18npool/source/localedata/data/localedata_others.map  1.10.10.4
i18npool/source/localedata/data/makefile.mk  1.33.10.4
i18npool/source/localedata/localedata.cxx  1.40.8.4
svx/source/dialog/langtab.src  1.67.112.8
Comment 22 ooo 2006-06-14 18:50:11 UTC
Reassigning to QA.

re-open issue and reassign to oc@openoffice.org
Comment 23 ooo 2006-06-14 18:50:17 UTC
reassign to oc@openoffice.org
Comment 24 ooo 2006-06-14 18:50:23 UTC
reset resolution to FIXED
Comment 25 oc 2006-06-28 13:46:19 UTC
verified in internal build cws_locales204
Comment 26 oc 2006-07-19 10:09:19 UTC
closed because fix available in src680_m176