Issue 62796 - Target %worldremote.mk is obsolete
Summary: Target %worldremote.mk is obsolete
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.3
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-05 20:54 UTC by quetschke
Modified: 2006-04-20 12:27 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to remove remote* stuff (4.74 KB, patch)
2006-03-08 04:55 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-03-05 20:54:04 UTC 
It looks like %worldremote.mk is obsolete in settings.mk is obsolete because
the
        @+echo # > ...
recipes don't work for non-4nt targets as tcsh treats the # as a comment and
ignores the rest.
Comment 1 quetschke 2006-03-06 15:29:52 UTC 
@pl: ause said I should ask you if the %worldremote.mk stuff is still used?
     If not I'll prepare a patch to remove it.
Comment 2 philipp.lohmann 2006-03-06 15:38:09 UTC 
It seems to me that this regards the old "remote=true" make rules, yes ? If so,
then that is obsolete for quite some time now.
Comment 3 quetschke 2006-03-06 16:10:37 UTC 
Thank you! I'll prepare a patch to scrap the `.IF "$(remote)"!=""` stuff.
Comment 4 quetschke 2006-03-06 16:15:21 UTC 
@pl: What about REMOTE_BUILD and REMOTE_BUILD_FLAG? Can they go away too?
Comment 5 philipp.lohmann 2006-03-06 16:25:08 UTC 
No idea, but hjs is in a way better position to know; he invented it.
Comment 6 quetschke 2006-03-06 17:04:36 UTC 
Quote from IRC:
<ause> vq: i might have known some time in the past... ;) if "remote=true" is
obsolete, REMOTE_* is also

My next CWS will show if someone still uses them, if noone complains they are
gone ;)
Comment 7 quetschke 2006-03-08 04:55:25 UTC 
Created attachment 34660 [details]
Patch to remove remote* stuff
Comment 8 quetschke 2006-03-08 05:02:39 UTC 
I grepped the sources for REMOTEDEF, REMOTELIB, REMOTE_ and case
insensitive \$[({]remote and didn't find more occurences that could be removed,
except:
solenv/config/ssolar.cmn:               REMOTE_BUILD_FLAG
but that is your domain.

Committed to vq29. Please verify!
Comment 9 hjs 2006-04-20 12:27:49 UTC 
.