Issue 64234 - function macro mktmp is cutting off leading whitespaces
Summary: function macro mktmp is cutting off leading whitespaces
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: dmake (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on: 81185
Blocks:
  Show dependency tree
 
Reported: 2006-04-10 19:54 UTC by quetschke
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch for dmake (3.50 KB, patch)
2007-08-28 19:24 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-04-10 19:54:02 UTC
The function macro $(mktmp ..) is cutting off leading whitespaces.

This is a follow-up issue for issue 46987.
Comment 1 quetschke 2007-08-28 19:24:50 UTC
Created attachment 47827 [details]
Patch for dmake
Comment 2 quetschke 2007-08-29 03:28:38 UTC
Patch (plus testcase) committed to dmake411.
Comment 3 quetschke 2007-08-29 03:29:01 UTC
Please verify
Comment 4 quetschke 2007-08-31 12:26:04 UTC
Hmm, this fix breaks the build because

$(TYPE) $(mktmp $(foreach,i,$(all_local_obj:b:+".obj") $@ : $(OBJ)$/$(i:+"\n"))
$(foreach,i,$(all_misc_obj:b:+".obj") $@ : $(OBJ)$/$(i:+"\n"))) >> $@

in rules.mk creates something like this:

../wntmsci10.pro/misc/all_cpp.dpobj : ../wntmsci10.pro/obj/_cpp.obj
 ../wntmsci10.pro/misc/all_cpp.dpobj : ../wntmsci10.pro/obj/_eval.obj
 ../wntmsci10.pro/misc/all_cpp.dpobj : ../wntmsci10.pro/obj/_getopt.obj

and the leading space makes this a recipe line.

This can probably be fixed by using
  $(@:^"\n") : $(OBJ)$/$i
instead.
Comment 5 quetschke 2007-09-01 09:02:52 UTC
issue 81185 handles potential fallout from the mktmp change. Back to FIXED.
Comment 6 hjs 2007-09-26 16:57:38 UTC
.
Comment 7 hjs 2007-12-21 13:40:57 UTC
dmake 4.11 is in use now