Issue 64244 - Clean up solenv/inc/startup/wnt/macros.mk
Summary: Clean up solenv/inc/startup/wnt/macros.mk
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: All Windows, all
: P4 Trivial (vote)
Target Milestone: OOo 2.0.3
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-11 04:03 UTC by quetschke
Modified: 2006-06-16 13:12 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch for solenv/inc (3.19 KB, patch)
2006-04-11 22:43 UTC, quetschke 		no flags Details | Diff
macros.mk resorted (1.99 KB, text/plain)
2006-04-26 14:06 UTC, hjs 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-04-11 04:03:30 UTC 
Instead of relying on $(SHELL)==$(COMSPEC) to identify 4nt vs. tcsh $(USE_SHELL)
should be used.
Comment 1 quetschke 2006-04-11 22:43:58 UTC 
Created attachment 35644 [details]
patch for solenv/inc
Comment 2 quetschke 2006-04-14 15:16:23 UTC 
Committed to vq30
Comment 3 quetschke 2006-04-17 16:23:47 UTC 
Works here. Reassigning for verification.
Comment 4 quetschke 2006-04-17 16:24:26 UTC 
@ause: Please verify
Comment 5 hjs 2006-04-26 13:24:39 UTC 
SHELL should be set before using $(shell ...). if you like, i can commit the fix
to your CWS
Comment 6 hjs 2006-04-26 14:06:33 UTC 
Created attachment 36057 [details]
macros.mk resorted
Comment 7 quetschke 2006-04-26 14:28:59 UTC 
Oops, yes, please do. Hmm, wonder how I managed to "test" that with W32-4nt.
Must have been a stale tree, sorry.
Comment 8 hjs 2006-04-26 14:42:01 UTC 
done. you may want to have a look if i did break something ;)
Comment 9 hjs 2006-04-26 17:57:58 UTC 
got fooled too... please have a look at the latest commit...
Comment 10 quetschke 2006-04-26 18:18:57 UTC 
:) This one looks good, but I cannot really test W32-4nt before tonight.
Comment 11 hjs 2006-05-03 17:04:38 UTC 
.
Comment 12 hjs 2006-06-16 13:12:48 UTC 
.