Issue 64296 - tools/inc/solar.h: SYSTEM_ID unused?
Summary: tools/inc/solar.h: SYSTEM_ID unused?
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-11 21:19 UTC by pavel
Modified: 2007-07-13 14:54 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-04-11 21:19:48 UTC
Hi,

the macro SYSTEM_ID is defined in solar.h as (e.g. for GNU/Linux/x86):

#define SYSTEM_UNXLNXI           9
...
#elif defined LINUX && defined X86
...
  #define SYSTEM_ID             SYSTEM_UNXLNXI

This is the only place where SYSTEM_UNXLNXI is used.

The other places referencing SYSTEM_ID are:

- module xmerge

  SYSTEM_ID is different SYSTEM_ID ;-)

- binfilter

bf_sfx2/source/appl/sfx2_appbas.cxx://STRIP001                       sal_uInt16
nSystem = SYSTEM_ID;

  It is commented anyway.

- svtools

source/misc/pver.cxx:   String aReturn( String::CreateFromInt32(SYSTEM_ID) );

  Also in commented part.

Does Sun use it somewhere? Can we remove it?
Comment 1 hjs 2007-01-30 12:19:56 UTC
both gone:
SYSTEM_ID and pver.[cxx|hxx]
Comment 2 hjs 2007-01-30 12:23:38 UTC
giving it a target...
Comment 3 rt 2007-02-05 09:06:18 UTC
Verified in CWS ause074
Comment 4 hjs 2007-07-13 14:54:18 UTC
.